Closed Bug 1274002 Opened 4 years ago Closed 4 years ago
Mochitest chrome is run with e10s enabled by default with mach
MozReview Request: Bug 1274002 - Disable e10s when running mochitest-chrome locally with mach, r?jmaher
58 bytes, text/x-review-board-request
When running with mach, mochitest-chrome wrongfully has e10s enabled. This is because the mochitest mach command dynamically sets the flavor after the fact. I.e options.chrome doesn't get set until after this check occurs: https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/mochitest_options.py#794 The fix should be to move that check later on in the harness. This doesn't affect automation, just running locally.
Review commit: https://reviewboard.mozilla.org/r/53652/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53652/
Attachment #8754004 - Flags: review?(jmaher)
Comment on attachment 8754004 [details] MozReview Request: Bug 1274002 - Disable e10s when running mochitest-chrome locally with mach, r?jmaher https://reviewboard.mozilla.org/r/53652/#review50400 lgtm
Attachment #8754004 - Flags: review?(jmaher) → review+
Given we ship e10s now, is there any reason to run these tests with e10s disabled (on desktop at least)? This bit me in bug 1416872. I've also found other webextension mochitest-chrome tests that are not quite working under e10s and am looking at transitioning them somehow in bug 1417639.
I had disabled all non-e10s tests but then received pushback for a few valid cases: 1) gecko runs on android which is non-e10s 2) firefox users can run gecko in non-e10s for legacy addons and other a11y/media reasons Right now these are enabled as windows7-debug only, if there are specific tests to turn off, I think that is a valid ask- I imagine in Q2 we could discuss turning all non-e10s off. As for mochitest-chrome, I don't think we run those specific tests in e10s mode, so on all platforms these only run in non-e10s. You can see all tests which are run as non-e10s only: https://searchfox.org/mozilla-central/search?q=e10s%3A+false&case=true&path=
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #6) > As for mochitest-chrome, I don't think we > run those specific tests in e10s mode, so on all platforms these only run in > non-e10s. The thing I particularly care about is I want these particular tests to run with e10s on desktop. I started to move them to mochitest-browser-chrome before I was reminded they would no longer run under android. They make use of the fact they are in chrome, but they are webextension tests which should IMO always run with e10s. Porting them to mochitest-plain is a chunk of effort as well, so I was wondering why we shouldn't just enable e10s for mochitest-chrome on desktop (or at least by some option). The patch in this bug seems to prevent any option to enable e10s for mochitest-chrome.  see https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/mochitest/chrome.ini
if you submit a patch with try results, I am happy to review it. My understanding is mochitest-chrome doesn't work in e10s mode.
You need to log in before you can comment on or make changes to this bug.