127409 - Changed news server name, but old name still shows in title bar

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Russell Odom]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.8) Gecko/20020204
BuildID:    2002020406

I had a news server configured. Due to changing ISPs, I changed the name of the
news server in 'Edit > Mail & Newsgroups account settings... > [news server] >
Server Settings > Server Name'. However, the name of the old server still
appears in the title bar when I am viewing a newsgroup. Exiting and restarting
Mozilla has no effect on this - the server name is still wrong.

Reproducible: Didn't try
Steps to Reproduce:
1. Create a new news account (e.g. news.x.net). Subscribe to a newsgroup (e.g.
alt.somegroup).
2. Read a newsgroup. Note the title bar - it will read 'alt.somegroup on news.x.net'
3. Go to 'Edit > Mail & Newsgroups account settings... > news.x.net > Server
Settings', and change the Server Name to 'news.y.net'
4. Now read a newsgroup. Look at the title bar.
5. Close and restart Mozilla. Title bar is still wrong.

Actual Results:  Title bar is still 'alt.somegroup on news.x.net'

Expected Results:  Title bar should read 'alt.somegroup on news.y.net'

Comment 1

[Olivier Cahagne]

wfm using build 2002022203 on Win2k.

Comment 2

[Russell Odom]

Just had a look in my profile - all the files and folders relating to this
server are still named with the name of the old server, not the new one - is
this where the erroneous name is coming from?

Comment 3

[[e-mail]]

I can see this. The window title is always the original host name, not the
current host name or the pretty name which IMHO should be used instead.

Comment 4

[[e-mail]]

Attachment: Proposed Patch

Change to use the pretty name instead of the original host name

Comment 5

[timeless]

Comment on attachment 74554 [details] [diff] [review]
Proposed Patch

this will need mailnews approval since it's a change from a hostname (albeit
wrong) to a pretty name

Comment 6

[jglick]

I agree the "account (pretty) name" should be used in the window title. This 
should apply to Mail accounts as well.

Comment 7

[Navin Gupta]

Attachment: patch

I think we should try to use server.prettyName because it will construct one if
there isn't one.

Comment 8

[[e-mail]]

Attachment: Updated my patch for bitrot

naving's patch is just like my patch (now that I've updated it for bitrot)
except that he's removed the {}s (which doesn't match the style of the rest of
the file) and he didn't fix the indentation.

Comment 9

[timeless]

Comment on attachment 89919 [details] [diff] [review]
Updated my patch for bitrot

commandglue.js r=timeless
the other stuff appears to be from some other bugs, any idea which ones?

Comment 10

[[e-mail]]

Comment on attachment 89919 [details] [diff] [review]
Updated my patch for bitrot

Forget this.

Comment 11

[[e-mail]]

Comment on attachment 89852 [details] [diff] [review]
patch

r=[e-mail] (although style in the rest of the file seems to be to
leave the {}s in).

Comment 12

[Navin Gupta]

David, can you sr the second patch ? thx.

Comment 13

[David :Bienvenu]

Comment on attachment 89852 [details] [diff] [review]
patch

sr=bienvenu

Comment 14

[Navin Gupta]

fix checked in. thx neil for initial patch. 

Comment 15

[[e-mail]]

Verified fixed in Build ID: 2002082004