Closed Bug 1274099 Opened 9 years ago Closed 9 years ago

Clarify the confirm() text for cancel all jobs

Categories

(Tree Management :: Treeherder, defect)

Product:
Tree Management
Component:
Treeherder
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KWierso, Assigned: KWierso)

Details

Attachments

(1 file)

[treeherder] KWierso:confirmtextfix > mozilla:master
47 bytes, text/x-github-pull-request
emorley
: review+
Details | Review
The confirm() dialogs ask "Are you sure?" and then you get "OK" and "Cancel" as options. I think we can clarify the text so it's not a yes/no question without yes/no answers.
Comment on attachment 8754150 [details] [review] [treeherder] KWierso:confirmtextfix > mozilla:master Arguably we could probably just drop the second sentence for each of these... eg "This will delete the exclusion." OK/Cancel "This will cancel all pending and running jobs for revision X" OK/Cancel "This will trigger all missing jobs for revision X" OK/Cancel "This will trigger all talos jobs for revision X" OK/Cancel
Attachment #8754150 - Flags: review?(emorley)
Assignee: nobody → wkocher
Attachment #8754150 - Flags: review?(emorley) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: