1274220 - Safebrowsing delays page loading for a few minutes

Status: RESOLVED DUPLICATE of bug 1254323

(Toolkit :: Safe Browsing, defect)

Description

[schultz]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160502172042

Steps to reproduce:

Loading a Website which had an accidental hash false-positive match in the local safebrowsing database. There were a lot of Resources with the same Base-URL and the Base-URL was, what actually triggered the Problem. Because the Hashes are generated for partial URLs as well, it was trying to verify the positive match with safebrowsing.google.com for a lot of URLs (>~ 100) and the service would block or FF would wait for 60 Seconds until verifying the rest.

Setting browser.safebrowsing.enabled to false prevents the Problem.


Actual results:

Website loading was delayed by several Minutes because of the forced Wait of 60 seconds per Batch. The Browser was also blocking other Websites completely during that time. Closing the browser was necessary to reproduce the error. With browser.safebrowsing.debug enabled I got an enormous output for the same partial Hash-Match.


Expected results:

Website should be loaded with only a very minor delay (hashresolver should only check once)

Comment 1

[schultz]

Attachment: This would trigger the delay, if the Base-URL had a match in the local safebrowsing shavar Database.

Comment 2

[schultz]

Attachment: Output of safebrowsing.debug = true

Comment 3

[schultz]

My Solution was to slightly tweak the Base-URL so that it wouldn't match the partial 4-byte-hash.