If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Should we always show the down arrow button when Containers are enabled?

RESOLVED FIXED

Status

()

Core
DOM: Security
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: baku, Unassigned)

Tracking

(Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [userContextId][userContextId-UI][domsecurity-active][uplift49-])

Attachments

(2 attachments)

(Reporter)

Description

a year ago
I'm filing bug to discuss about this issue. Currently we show the 'down arrow button' only when we have too many tabs and those overflow the size of the FF window. At some point, we discussed to show the 'down arrow button' always in order to give the user the possibility to open containers from the popup menu.

But now we also have the hamburger menu icon. Do we still want to implement this feature?
Probably not. Bram, what do you think?

Updated

a year ago
Priority: -- → P1
Whiteboard: [userContextId][userContextId-UI]
Assignee: nobody → jkingston
Status: NEW → ASSIGNED
Whiteboard: [userContextId][userContextId-UI] → [userContextId][userContextId-UI][domsecurity-active]
Created attachment 8756859 [details]
Screenshot from 2016-05-26 15-11-10.png

I'll be honest I think it looks a little odd with the menu forced here when it is only ever visible usually when there are too many tabs.

Tanvi what do you think?

Comment 2

a year ago
Hi Bram,

We discussed the attached screenshot in the Containers meeting today.  And have some questions/concerns:

We originally wanted a url bar access point to new container tabs.  We didn't want to add an extra UI element, so we built into the drop down arrow.  The drop down arrow only appears when too many tabs are present though.  We need the drop down arrow when there aren't too many tabs present.  But in that case, what should it look like?

We think it should be next to the plus sign instead of all the way on the right hand side.  This way, it is easier for users who want to create a new tab to select between the + sign and the drop down arrow.

I think the New Container Tab item should go above the "Undo Close Tab" option (both when there are a few tabs and when there are too many tabs).

When there are not too many tabs, the new container options should be in the main menu instead of the submenu.  So when the user clicks the down arrow they see the following on top:
icon + New Personal Tab
icon + New Work Tab
icon + New Shopping Tab
icon + New Bank Tab

Then what comes after that?  Should we include "Undo Close Tab".  Below Undo Close Tab, should we include the list of open tabs?  Ideally, we wouldn't include them and the arrow would just be for new container tabs.  But that is inconsistent user experience, because sometimes the arrow will show open tabs and other times it won't.  So maybe we do need to include these options.

Bram, can you tell us what you think it should look like?  And provide a rough mockup for the design?  Thank you!
Flags: needinfo?(bram)

Updated

a year ago
Blocks: 1276412
(In reply to Tanvi Vyas - behind on reviews [:tanvi] from comment #2)
> […]  We need the drop down arrow when there aren't too many tabs
> present.  But in that case, what should it look like?
> 
> We think it should be next to the plus sign instead of all the way on the
> right hand side.

Yes. In my previous mockup, the arrow was all the way on the right-hand side, but it’s better to put it right next to the plus in this specific situation.


> When there are not too many tabs, the new container options should
> be in the main menu instead of the submenu.

One thing I would add here is a menu label (not clickable) called “New Container Tab”. With this label, we won’t have to repeat “New [container_name] Tab” phrase over and over again. Just call it “[container_name]” like in all the other menus.

The Bookmarks menu uses this pattern for the “Recently Bookmarked” section.


> Then what comes after that? Should we include "Undo Close Tab".
> Below Undo Close Tab, should we include the list of open tabs?

Yes. We should include “Undo Close Tab”, as well as the list of all open tabs. I know this makes the list longer, but it makes it consistent.


In summary, when there are only a few tabs:
* Arrow moves next to the plus symbol, wherever the plus may be located
* Drop down main menu contains list of containers

When there are many tabs:
* Arrow moves to the right-side of the tab bar. It’s still next to the plus symbol, but the plus symbol don’t have a tab-shaped outline there
* Drop down contains a menu item called “New Container Tabs”, that will open a submenu with list of containers
Flags: needinfo?(bram)
Created attachment 8757735 [details]
containers - tab-bar-context-menu - few tabs
(Reporter)

Updated

a year ago
Blocks: 1245262

Comment 5

a year ago
This is more of a UX bug.  The implementation is in https://bugzilla.mozilla.org/show_bug.cgi?id=1272416.  So unassigning Jonathan.  Needinfo'ing Bram to work with Steven Horlander on this, since Steven has some issues with it.
https://bugzilla.mozilla.org/show_bug.cgi?id=1272416#c31
Assignee: jkingston → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(bram)
We should avoid significantly altering a common control for this.

If you are looking for a more a visible entry point for making a container tab you could bump the Container icon from the customize palette into the Firefox Menu.

If you are looking for an advanced way to quickly add containers you could look into adding a long press menu to the plus icon like we do for History on the back/forward buttons.

Comment 7

a year ago
Thanks for your feedback Stephen!

Okay, then lets do the following:

* Bug to move containers item from customize section to the hamburger menu
https://bugzilla.mozilla.org/show_bug.cgi?id=1279337

* Bug to show a containers menu on long-press of the plus button already exists, but Bram suggested we do the down arrow instead.  I'll update and prioritize that bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1272256

* Close won't fix the always show the down arrow bug https://bugzilla.mozilla.org/show_bug.cgi?id=1272416 for now.

(In reply to Stephen Horlander [:shorlander] from comment #6)
> We should avoid significantly altering a common control for this.
> 
> If you are looking for a more a visible entry point for making a container
> tab you could bump the Container icon from the customize palette into the
> Firefox Menu.
> 
> If you are looking for an advanced way to quickly add containers you could
> look into adding a long press menu to the plus icon like we do for History
> on the back/forward buttons.
I always wondered how I could invoke that History menu!  I saw it sometimes and really appreciated it.  But then when I wanted it, I didn't know how to find it.

Comment 8

a year ago
Resolving this bug.
Status: NEW → RESOLVED
Last Resolved: a year ago
Flags: needinfo?(bram)
Resolution: --- → FIXED
Whiteboard: [userContextId][userContextId-UI][domsecurity-active] → [userContextId][userContextId-UI][domsecurity-active][uplift49-]
You need to log in before you can comment on or make changes to this bug.