Closed
Bug 1274328
Opened 9 years ago
Closed 9 years ago
Make it possible to hide "Windows 7 VM 32-bit" tests
Categories
(Tree Management :: Treeherder, defect, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: camd)
Details
Attachments
(1 file)
On try we are running both the working "Windows 7 32-bit try opt test mochitest-4" jobs and the not-yet-working "Windows 7 VM 32-bit try opt test mochitest-4" jobs. We want to hide the ones with VM in the buildername, because they are causing enormous developer confusion and ridiculous numbers of retriggers.
I created an exclusion named "Win 7 VM mochitests" and used the platform "Windows 7 VM 32-bit try (unknown)" but as the visible orange jobs in https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ba9004cddb533a8ccc64f330d983f76d6df5330&filter-searchStr=windows%207%20mochitest-4 show, it doesn't actually hide them.
If jmaher has to change his buildername, he can and will, but that seems suboptimal, and the broken platforms which include bits of the tree name (there's also Windows 7 VM 32-bit fx-t (unknown) etc.) make it seem like TH isn't ingesting them correctly.
Comment 1•9 years ago
|
||
what is worse is we want some "windows 7 vm" jobs to show up by default, but exclude specific ones (really all mochitests related jobs today, a subset next week)
Reporter | ||
Comment 2•9 years ago
|
||
That shouldn't be any problem, you just put the particular jobs you want to hide in the exclusion (I only put in m-4 because I needed an example and it's the most horrifying one).
Comment 3•9 years ago
|
||
so to confirm there is no way to do this now, comment #2 is referring to how things should work when this is fixed?
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → cdawson
Assignee | ||
Comment 4•9 years ago
|
||
I'll take a look into this.
Updated•9 years ago
|
Priority: -- → P1
Assignee | ||
Comment 5•9 years ago
|
||
Working on a fix for this now. I am going to separate Win 7 VM from Win 7 as platforms. So you'll see the VM ones one their own line, when visible. This is the best way to create a distinguishing characteristic we can exclude by.
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
OK, This appears to be working. I'm going to push to stage for a test against more data.
Assignee | ||
Comment 8•9 years ago
|
||
those platforms were showing up oddly before. This should cause the platforms to show in the exclusion editor as "windows7-32 VM (x86)" and "windows7-32 (x86)".
Assignee | ||
Updated•9 years ago
|
Attachment #8759892 -
Flags: review?(emorley)
Assignee | ||
Comment 9•9 years ago
|
||
ok, this is working well on stage at the moment. I just created a second exclusion that excluded only Win 7 VM mda jobs. The normal win 7 ones show, but the vm ones are excluded properly.
Comment 10•9 years ago
|
||
Comment on attachment 8759892 [details] [review]
[treeherder] mozilla:win-vm-exclude > mozilla:master
I think the regex might not be quite right - have left some comments :-)
Attachment #8759892 -
Flags: review?(emorley) → review-
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8759892 [details] [review]
[treeherder] mozilla:win-vm-exclude > mozilla:master
Good points, all. I re-worked the regex and the vm string.
Attachment #8759892 -
Flags: review- → review?(emorley)
Updated•9 years ago
|
Attachment #8759892 -
Flags: review?(emorley) → review+
Comment 12•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/98de0a9cb1e6fe7ce4ccc1325f859219a3ed08cd
Bug 1274328 - Make it possible to hide Windows 7 VM 32-bit tests
Assignee | ||
Comment 13•9 years ago
|
||
Ok, this should be fixed now with this merge. I will push to stage shortly. We are working on an issue with autoclassifying on prod right now, so we may not push new code there till we have a fix. Unless this is critical enough to warrant a cherry-pick for now.
Philor: what's your opinion?
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(philringnalda)
Reporter | ||
Comment 15•9 years ago
|
||
Been a week since anyone asked me why their try push was completely broken on Windows, I doubt there's any need to cherrypick at this point.
Severity: blocker → normal
Finally got a prod push yesterday, so I went ahead and hid the clipboard and gpu jobs on the VM platforms.
You need to log in
before you can comment on or make changes to this bug.
Description
•