1274392 - Make echoCancellation:false flip the other audio processing defaults to false

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

We've discussed the need for sites to be able to disable all audio processing without a shopping list of constraints that may grow in the future:

    audio: {
      echoCancellation: false,
      mozAutoGainControl: false,
      mozNoiseSuppression: false
    }

Of these, echoCancellation is currently the lone standardized audio processing constraint.

Apparently, Chrome disables all audio processing on echoCancellation:false [1]. This seems reasonable considering that, for sites that don't specify, we browsers get to make a best guess about what they want.

For Firefox, the idea would be that mozNoiseSuppression would default to false if echoCancellation:false is specified, and default to true otherwise (mozAutoGainControl already defaults to false, but if that were to change, it would adopt the same rule, as would future audio-processing constraints we decide to surface).

That's the idea.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=397959#c6

Comment 1

[Paul Adenot (:padenot)]

Sounds good.

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P1->P2 to align with new Mozilla triage process

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 4

[Zamar Ac]

On TextNow website (https://www.textnow.com/) placing a call via WebRTC in Firefox 64.0b8 64-bit for Windows 10 results in low Mic volume heard by the other call party. Changing Mic settings like AGC in Windows Sound control panel doesn't notably raise the Mic volume on Texnow website, while improving it in some Windows applications.

Not sure if this is the right bug, but pls add Echo Cancellation, Gain Control with a slider or range of available values, and Noise Suppression to audio processing constrains available via FF interface and changeable for different websites, or accessible in about:config and set for all websites.

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1274392 - When echo cancellation is disabled, disable automatic gain control and noise suppression as well. r?jib

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33a1a7271fe3
When echo cancellation is disabled, disable automatic gain control and noise suppression as well. r=jib

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/33a1a7271fe3