Closed
Bug 1274508
Opened 9 years ago
Closed 9 years ago
The Homepage icon should not be displayed in the toolbar
Categories
(Firefox for iOS :: General, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: SimonB, Assigned: jhugman)
References
Details
Attachments
(2 files)
Show Homepage Icon in menu option is checked.PNG
Build 57cc05c7
Device IPhone 6S (9.2)
Steps to reproduce:
1. Go to Settings -> Homepage and check the 'Show Homepage Icon In Menu' option
2. Open a new tab
3. Change device orientation to landscape
4. Change device orientation to portrait
Actual results:
- The Homepage button will be displayed in the toolbar after changing the device orientation to landscape and back to portrait.
Expected results:
- The Homepage button should be displayed in the toolbar only when the 'Show Homepage Icon In Menu' is checked off.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8755452 -
Flags: review?(etoop)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8755452 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1846
LGTM
Attachment #8755452 -
Flags: review?(etoop) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Merged.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 4•9 years ago
|
||
Tested on 3c8f33c5.
The Homepage icon is displayed correctly.
Status: RESOLVED → VERIFIED
|
|
||
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•