1274528 - Don't enforce layers.max-active when layerizing items with different AGRs

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jamie Nicol [:jnicol] out of office until 6th Jan]

In bug 1231818 it was made so that when the max layer limit is reached we attempt to use an existing layer with the item's ancestor AGR instead of creating a layer for the item's correct AGR. This breaks async scrolling on pages with many active layers. (See bug 1252711)

The reason for making that change was to try and control memory usage. I don't think it made a difference. In fact, this change has made things worse in some cases, as in order to have fewer layers we end up with bigger layers which change size more often. The specific website which prompted that change will now layerize much better anyway, due to bug 1243589 and bug 1247554. I propose we revert this change.

Comment 1

[Jamie Nicol [:jnicol] out of office until 6th Jan]

Attachment: MozReview Request: Bug 1274528 - Don't enforce layers.max-active when layerizing items with different AGRs; r?mstange

This reverts bug 1231818, as it caused problems with async scrolling on
pages with too many active layers.

Review commit: https://reviewboard.mozilla.org/r/54252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54252/

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8754812 [details]
MozReview Request: Bug 1274528 - Don't enforce layers.max-active when layerizing items with different AGRs; r?mstange

https://reviewboard.mozilla.org/r/54252/#review50942

Comment 3

[Jamie Nicol [:jnicol] out of office until 6th Jan]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea8be6ebceca9031cef2e4519cd3916a0dcbe980

requesting checkin please

Comment 4

[Carsten Book [:Tomcat]]

seems has problems to apply, could you take a look ? thanks!

applying 0f820cd1b448
patching file layout/base/FrameLayerBuilder.cpp
Hunk #5 FAILED at 4190
1 out of 5 hunks FAILED -- saving rejects to file layout/base/FrameLayerBuilder.cpp.rej

Comment 5

[Jamie Nicol [:jnicol] out of office until 6th Jan]

Attachment: rebased patch

That was a wee bit old, I rebased before the try push but didn't upload the new patch. This one should work.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26bd1c34e1f8

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/26bd1c34e1f8