Closed
Bug 1274549
Opened 9 years ago
Closed 9 years ago
Missing top and bottom padding for multi-line settings rows text on small screen devices
Categories
(Firefox for iOS :: General, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: SimonB, Assigned: sleroux)
References
Details
Attachments
(2 files)
Screenshot of the issue.
Build: 57cc05c7
Device: IPhone 4S ( 9.3.1)
Steps to reproduce:
1. Go to Settings
2. Tap on the Homepage button
Actual results:
- There is no top and bottom padding for the "Show Homepage Icon In Menu" text.
Expected results;
- The text container should be enlarged.
|
||
Updated•9 years ago
|
Assignee: nobody → jhugman
|
||
Updated•9 years ago
|
Rank: 8
|
|
||
Updated•9 years ago
|
Assignee: jhugman → nobody
|
|
||
Updated•9 years ago
|
Summary: Missing top and bottom padding for "Show Homepage Icon In Menu " text on small screen devices → Missing top and bottom padding for multi-line settings rows text on small screen devices
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8756995 -
Flags: review?(bnicholson)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8756995 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1856
Works for me!
Attachment #8756995 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
master 80a244317f27783d9026d7d6efde873011f1e6e3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 4•9 years ago
|
||
The top and bottom padding for multi-line settings rows text on small screen devices is correct on master 5979d61c.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•