Closed
Bug 1274570
Opened 9 years ago
Closed 9 years ago
Browser layout breaks when 'Home' button is added to toolbar
Categories
(Firefox for iOS :: General, defect)
Tracking
()
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 5.0+ | --- |
People
(Reporter: sleroux, Assigned: jhugman)
References
Details
Attachments
(3 files)
Simulator Screen Shot May 20, 2016, 9.48.28 AM.png
master dff2815680a48ceaed30eb88d7baa56e5f181028
I pulled down the repo this morning and tried running in the iPhone 6 8.4 simulator and noticed that layout was broken on the lower toolbar with the share button displaying in the top left of the screen.
Rotating to landscape and back fixes the layout and displays the home button in and the end with the menu button no longer in the center.
|
Reporter | |
Comment 1•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jhugman
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8755447 -
Flags: review?(etoop)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8755447 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1845
LGTM
Attachment #8755447 -
Flags: review?(etoop) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Merged.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 6•9 years ago
|
||
Tested on 3c8f33c5.
The Browsers layout no longer breaks when 'Home' button is added.
Status: RESOLVED → VERIFIED
|
|
||
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•