Closed Bug 1274609 Opened 3 years ago Closed 3 years ago
replace uses of Ci
.ns IDOMNode Filter constants
While working in bug 1265854 I noticed another use of constants from Ci.nsIDOMNodeFilter. There aren't many so they should be easy to replace.
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
Assignee: nobody → gtatum
Status: NEW → ASSIGNED
Iteration: --- → 50.1
Assignee: gtatum → nobody
Status: ASSIGNED → NEW
Iteration: 50.1 → ---
Hi, I'd like to take this bug :) I think this bug is very similar to Bug 1265854, so I'll make a patch like that.
Hi James, I made a patch similar to Bug 1265854 to replace the Ci.nsIDOMNodeFilter constants. Thanks!
Attachment #8769969 - Flags: review?(jlong)
Try server looks good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb1fad5a62c4
Comment on attachment 8769969 [details] [diff] [review] 0001-Bug-1274609-Replace-uses-of-Ci.nsIDOMNodeFilter-cons.patch Review of attachment 8769969 [details] [diff] [review]: ----------------------------------------------------------------- Awesome, thank you very much! Looks good!
Attachment #8769969 - Flags: review?(jlong) → review+
Do you need help checking this in?
Can you also do a try run with xpcshell tests?
Yeah, you can check this in if you think it's ready. https://treeherder.mozilla.org/#/jobs?repo=try&revision=83e128bf7954 Xpcshell test looks good too. Thanks!
Hi James, I'm not sure if you had checked the test above, otherwise I'd like to check this patch in :)
Fwiw, I prefer doing a full try run each time. You can use these flags: "try: -b do -p linux,linux64,linux64-asan,linux64-st-an,linux64-valgrind,macosx64,macosx64-st-an,macosx64-mulet,win32,win32-mulet,win64 -u xpcshell,mochitests -t none" This is a pretty small patch and those tests past, so I will commit it. Doing it a full run makes sure you didn't miss anything. For some reason it looks like the mochitests didn't run on Windows.
You can add the keyword "checkin-needed" and the sheriffs will commit it automatically within a day or two.
Pushed by email@example.com: https://hg.mozilla.org/integration/fx-team/rev/d3c71a72e591 Replace uses of Ci.nsIDOMNodeFilter constants. r=jlongster
You need to log in before you can comment on or make changes to this bug.