Closed
Bug 1274796
Opened 8 years ago
Closed 8 years ago
spacing around namedspaces is not accepted for MathML lengths
Categories
(Core :: MathML, defect)
Core
MathML
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: fredw, Assigned: jkitch)
References
()
Details
Attachments
(1 file, 1 obsolete file)
11.21 KB,
patch
|
Details | Diff | Splinter Review |
The RelaxNG syntax for MathML lengths is pattern = '\s*((-?[0-9]*([0-9]\.?|\.[0-9])[0-9]*(e[mx]|in|cm|mm|p[xtc]|%)?)|(negative)?((very){0,2}thi(n|ck)|medium)mathspace)\s*' It seems that we do not support spacing around namedspaces e.g. <mspace width=" thickmathspace "/> See http://tests.mathml-association.org/mathml/relations/css-styling/lengths-3.html
Assignee | ||
Comment 1•8 years ago
|
||
nsMathMLElement::ParseNumericValue parses numeric values using a copy of the string with whitespace removed, but then uses the original string for the named spaces. The attached patch parses numeric and named spaces using the same white-space suppressed string.
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8755160 [details] [diff] [review] patch.diff Review of attachment 8755160 [details] [diff] [review]: ----------------------------------------------------------------- OK, that one was easy. Thanks!
Attachment #8755160 -
Flags: review?(fred.wang) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=557db9ff007e&selectedJob=21349863
Keywords: checkin-needed
Comment 5•8 years ago
|
||
Backed out for failing test_lengths-3.html on Android. Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/dd1492bae3eb Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=28566503&repo=mozilla-inbound
Flags: needinfo?(jkitch.bug)
Comment 6•8 years ago
|
||
08:55:24 INFO - 105 INFO TEST-START | layout/mathml/imptests/test_lengths-3.html 08:55:24 INFO - 106 INFO TEST-UNEXPECTED-FAIL | layout/mathml/imptests/test_lengths-3.html | Units - Units: assert_approx_equals: ex expected 500 +/- 1 but got 501.66668701171875 08:55:24 INFO - 107 INFO TEST-UNEXPECTED-FAIL | layout/mathml/imptests/test_lengths-3.html | Trimming of space - Trimming of space: assert_approx_equals: ex expected 500 +/- 1 but got 501.66668701171875
Reporter | ||
Comment 7•8 years ago
|
||
I think increasing the tolerance is fine.
Assignee | ||
Comment 8•8 years ago
|
||
My first thought is to bump the tolerance up to 2. If not, this isn't something that I can debug.
Flags: needinfo?(jkitch.bug)
Assignee | ||
Comment 9•8 years ago
|
||
Attachment #8755160 -
Attachment is obsolete: true
Assignee | ||
Comment 10•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae314add6edb https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c77f4f20d7b
Keywords: checkin-needed
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d6ca1f3a98
Keywords: checkin-needed
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d2d6ca1f3a98
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•