1274796 - spacing around namedspaces is not accepted for MathML lengths

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang Nélar]

The RelaxNG syntax for MathML lengths is

  pattern = '\s*((-?[0-9]*([0-9]\.?|\.[0-9])[0-9]*(e[mx]|in|cm|mm|p[xtc]|%)?)|(negative)?((very){0,2}thi(n|ck)|medium)mathspace)\s*' 

It seems that we do not support spacing around namedspaces e.g.

<mspace width=" thickmathspace "/>

See http://tests.mathml-association.org/mathml/relations/css-styling/lengths-3.html

Comment 1

[James Kitchener (:jkitch)]

Attachment: patch.diff

nsMathMLElement::ParseNumericValue parses numeric values using a copy of the string with whitespace removed, but then uses the original string for the named spaces.

The attached patch parses numeric and named spaces using the same white-space suppressed string.

Comment 2

[Frédéric Wang Nélar]

Comment on attachment 8755160 [details] [diff] [review]
patch.diff

Review of attachment 8755160 [details] [diff] [review]:
-----------------------------------------------------------------

OK, that one was easy. Thanks!

Comment 3

[James Kitchener (:jkitch)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=557db9ff007e&selectedJob=21349863

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/607941762a73

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing test_lengths-3.html on Android.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/dd1492bae3eb
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=28566503&repo=mozilla-inbound

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

08:55:24     INFO -  105 INFO TEST-START | layout/mathml/imptests/test_lengths-3.html
08:55:24     INFO -  106 INFO TEST-UNEXPECTED-FAIL | layout/mathml/imptests/test_lengths-3.html | Units - Units: assert_approx_equals: ex expected 500 +/- 1 but got 501.66668701171875
08:55:24     INFO -  107 INFO TEST-UNEXPECTED-FAIL | layout/mathml/imptests/test_lengths-3.html | Trimming of space - Trimming of space: assert_approx_equals: ex expected 500 +/- 1 but got 501.66668701171875

Comment 7

[Frédéric Wang Nélar]

I think increasing the tolerance is fine.

Comment 8

[James Kitchener (:jkitch)]

My first thought is to bump the tolerance up to 2.

If not, this isn't something that I can debug.

Comment 9

[James Kitchener (:jkitch)]

Attachment: patch.diff

Comment 10

[James Kitchener (:jkitch)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae314add6edb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c77f4f20d7b

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d6ca1f3a98

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2d6ca1f3a98