1274832 - KDE Wallet password integration addon breaks Firefox Sync

Status: RESOLVED INVALID

(Firefox :: Sync, defect)

Description

[Aitor]

Attachment: error-sync-1463918505603.txt

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 2016050300

Steps to reproduce:

After detecting this issue (having to login into Firefox sync on every restart):
 1. I disconnect from my Firefox sync account and close Firefox.
 2. Delete "signedInUser.json" file from profile folder (just in case) which stored "null" string
 3. Start Firefox and login again into Firefox-sync without issues
 4. Restart Firefox
 5. After some seconds, the warning sign is displayed on menu icon indicating that I need to login into Firefox sync again.
 6. Opening Firefox sync login let me log in again with no problem.
 7. On any further Firefox restart, same thing happens again

Logs seem to complain about clock offset:
1463918505039	Hawk	DEBUG	(Response) /account/keys: code: 401 - Status text: Unauthorized
1463918505040	Sync.RESTResponse	TRACE	Processing response headers.
1463918505040	Hawk	DEBUG	Clock offset vs https://api.accounts.firefox.com/v1: -1040
1463918505040	Hawk	DEBUG	Received 401 for /account/keys: retrying
1463918505306	Hawk	DEBUG	(Response) /account/keys: code: 401 - Status text: Unauthorized
1463918505306	Sync.RESTResponse	TRACE	Processing response headers.
1463918505306	Hawk	DEBUG	Clock offset vs https://api.accounts.firefox.com/v1: -306
1463918505307	FirefoxAccounts	ERROR	error GETing /account/keys: {"code":401,"errno":110,"error":"Unauthorized","message":"Invalid authentication token in request signature","info":"https://github.com/mozilla/fxa-auth-server/blob/master/docs/api.md#response-format"}

Software Details:
OS: Linux Apidell 4.5.4-1-default #1 SMP PREEMPT Wed May 11 15:23:21 UTC 2016 (db90c25) x86_64 x86_64 x86_64 GNU/Linux
Distro: OpenSuse Tumbleweed
Desktop environment: Plasma Workspace 5.6.3, KDE Frameworks 5.22, Qt 5.6.0
Firefox version: 46.0.1
NTP Server: 0.opensuse.pool.ntp.org
Hardware clock: UTC
TimeZone: IST (Irish Standard Time)



Actual results:

Firefox sync is unable to log in automatically on Firefox restart


Expected results:

Firefox sync should stay logged in until I explicitly disconnect it

Comment 1

[Mark Hammond [:markh] [:mhammond]]

The "clock offset" message is expected. Unfortunately, the log is not conclusive, but I suspect an addon might be involved. Can you please list the addons you have installed, and try in "safe mode" to see if the problem is still reproducible? In particular, I'm looking for an addon that attempts to augment or replace the "login manager" for saving passwords.

Comment 2

[Aitor]

You are right! After disabling "KDE Wallet password integration" (I tried with "KDE5 Wallet password integration" as well and got the same buggy behavior) it works as expected.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Thanks for the update! Hopefully the new title and blocking bug 1166571 will make this easier to find in the future for others.