1274844 - Install BinScope Binary Analyzer on TC firefox desktop Windows build AMIs

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Pete Moore [:pmoore][:pete]]

See e.g. https://dxr.mozilla.org/mozilla-central/rev/16663eb3dcfa759f25b5e27b101bc79270c156f2/build/win32/autobinscope.py

Presumably used in buildbot builds, see e.g. https://dxr.mozilla.org/mozilla-central/rev/16663eb3dcfa759f25b5e27b101bc79270c156f2/testing/mozharness/configs/builds/releng_base_windows_32_builds.py#73

Comment 1

[Pete Moore [:pmoore][:pete]]

Can be downloaded from https://www.microsoft.com/en-us/download/details.aspx?id=11910

Mike, can you confirm if this is still needed?

Comment 2

[Mike Hommey [:glandium]]

I have no clue.

Comment 3

[Rob Thijssen [:grenade (EET/UTC+0300)]]

added to win2012 manifest here: https://github.com/MozRelOps/OpenCloudConfig/commit/e6e107a160ef36222f4cc252a2a6a40e21210596

Comment 4

[Pete Moore [:pmoore][:pete]]

It looks like the binscope links are no longer available. I did find "BinScope 2014" here - not sure if it is needed?

Greg - do you have any idea? (also see links in comment 0)

https://www.microsoft.com/en-us/download/details.aspx?id=44995

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

can we get a documented reason for having this and confirm it is valid before doing this?  As per comment 2, I am not sure.

Comment 6

[Pete Moore [:pmoore][:pete]]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #5)
> can we get a documented reason for having this and confirm it is valid
> before doing this?  As per comment 2, I am not sure.

Looks to me like it is used here:

https://dxr.mozilla.org/mozilla-central/rev/20d57b9c4183973af4af5e078dff2aec0b74f928/build/win32/Makefile.in#7-14

Comment 7

[Pete Moore [:pmoore][:pete]]

It looks like we checked the binaries in to OpenCloudConfig:

  * https://github.com/mozilla-releng/OpenCloudConfig/commit/76edb6b28de33f1569425ae51ce912e41487b74d

I guess we should make these tooltool private artifacts now.

Comment 8

[Pete Moore [:pmoore][:pete]]

mshal confirmed it is used and was introduced in bug 642243.

Comment 9

[Pete Moore [:pmoore][:pete]]

Just discovered bug 1236356 so assigned that to myself. Will close this old bug in favour of doing the work in there.