1274874 - Clear review flags when creating redirects

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Janet Swisher]

What feature should be changed? Please provide the URL of the feature if possible.
==================================================================================
If a page has review flags set when it is redirected to a different page, the original page should have its review flags cleared when the redirect is created.

What problems would this solve?
===============================
The same page can be reached multiple ways from the needs-review listing because both the redirected page and its target have the review flag set. 

This can be avoided if editors remember to clear review flags manually before creating redirects. But editors are fallible humans who forget things.

Who would use this?
===================
This would save brain cycles for editors creating redirects, and confusion for editors using needs-review listings. 

What would users see?
=====================
There may not need to be any extra UI; just do it automatically. If necessary, put up a notification.

What would users do? What would happen as a result?
===================================================
Users would create redirects as they currently do. As part of the process of creating a redirect for a page, the review flags on that page would be cleared.

Is there anything else we should know?
======================================
Case in point at time of this writing: On https://developer.mozilla.org/en-US/docs/needs-review/editorial there are entries for:

* <a href="/en-US/docs/Web/API/HTMLElement/click">HTMLElement.click()</a>
* <a href="/en-US/docs/Web/API/HTMLInputElement/click">click</a>

These both lead to the former location, as the latter is a redirect to the former. If you go to https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/click$edit you can see the review flag that is responsible for the latter entry. There was also an entry for /en-US/docs/Web/API/HTMLButtonElement/click until I fixed it, confirming my hypothesis about the root cause of this behavior.

Comment 1

[John Whitlock [:jwhitlock]]

For a quick fix, redirects should be excluded from the needs-review pages.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/6d58485636965f88d430351dff47bb2a65223371
bug 1274874: Remove low-value pages from review

Remove redirects, user pages, archive pages, and others from the list of
documents needing technical or editiorial review, or translation.

https://github.com/mozilla/kuma/commit/f0ae239bb72216b01bf112e2f647606c80f3d15d
Merge pull request #4463 from jwhitlock/background-list-1392457

bug 1392457, 1274874: Improve document list views

Comment 3

[John Whitlock [:jwhitlock]]

The "needs review" pages now omit:

* Redirects
* Pages under /Archive
* Legacy MindTouch Pages with slugs starting with User:, Talk:, User_Talk:, Template_talk:, and Project_talk: