Closed Bug 1274884 Opened 4 years ago Closed 4 years ago

[webvtt] Remove/add cues which when the TextTrack::mMode is changed.

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: bechen, Assigned: bechen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We should add the cues which mode is showing/hidden into TextTrackManager::mNewCues.
And remove the cues from TextTrackManager::mNewCues if they become disable.
Comment on attachment 8755777 [details]
MozReview Request: Bug 1274884 - Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian

https://reviewboard.mozilla.org/r/54800/#review51580
Attachment #8755777 - Flags: review?(giles) → review+
Blocks: webvtt
Depends on: 1275808
Comment on attachment 8755777 [details]
MozReview Request: Bug 1274884 - Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54800/diff/1-2/
Comment on attachment 8755777 [details]
MozReview Request: Bug 1274884 - Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54800/diff/2-3/
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cbc8d093dfa
Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2cbc8d093dfa
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.