1274884 - [webvtt] Remove/add cues which when the TextTrack::mMode is changed.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Benjamin Chen [:bechen]]

We should add the cues which mode is showing/hidden into TextTrackManager::mNewCues.
And remove the cues from TextTrackManager::mNewCues if they become disable.

Comment 1

[Benjamin Chen [:bechen]]

Attachment: MozReview Request: Bug 1274884 - Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian

Review commit: https://reviewboard.mozilla.org/r/54800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54800/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8755777 [details]
MozReview Request: Bug 1274884 - Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian

https://reviewboard.mozilla.org/r/54800/#review51580

Comment 3

[Benjamin Chen [:bechen]]

Comment on attachment 8755777 [details]
MozReview Request: Bug 1274884 - Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54800/diff/1-2/

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8755777 [details]
MozReview Request: Bug 1274884 - Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54800/diff/2-3/

Comment 5

[Benjamin Chen [:bechen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=99a03f66d558

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cbc8d093dfa
Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2cbc8d093dfa