1274888 - Crash in mozilla::EventStateManager::GetContentViewer

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-c5e65108-90ac-4d3e-b0e4-8e6172160520.
=============================================================

We've had 6 crashes with this signature in the past 8 days in Nightly:

https://crash-stats.mozilla.com/signature/?product=Firefox&date=%3E%3D2016-04-20&signature=mozilla%3A%3AEventStateManager%3A%3AGetContentViewer&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&page=1#reports

The crash address is always 0x0, so it looks like a straightforward null deref, I looked at a minidump and GetWindow() was null.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Add a null check in mozilla::EventStateManager::GetContentViewer

Comment 2

[Ting-Yu Chou [:ting] (away)]

Comment on attachment 8755266 [details] [diff] [review]
Add a null check in mozilla::EventStateManager::GetContentViewer

Thanks for fixing this, I feel embarrassed that I'm making new crashes.

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5af962632d2e36b8200bcaa03b379aa1368defcb
Bug 1274888 - Add a null check in mozilla::EventStateManager::GetContentViewer. r=ting.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5af962632d2e