1274924 - GeckoDriver.getTextFromDialog() throws "TypeError: can't convert null to object"

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Johan Lorenzo [:jlorenzo]]

I don't have a reduced test case yet, but I can always repro this failure with this test[1]. If I understand correctly, under a certain set of conditions, `this.dialog.ui` doesn't have a value yet[2]. I proposed a workaround for the Selenium JS client at [3].

I believe, we can just extend the if condition just above[4] to make sure ui is not equal to null. I'll give it a try.

[1] https://github.com/fxbox/foxbox/blob/42c347565b2cbdfd9f453b7b78b234effe841ee3/test/selenium/sessions_ui_test.js#L99 . Failed execution at: https://travis-ci.org/fxbox/foxbox/jobs/131700352#L1482
[2] https://dxr.mozilla.org/mozilla-central/rev/16663eb3dcfa759f25b5e27b101bc79270c156f2/testing/marionette/driver.js#2513
[3] https://github.com/SeleniumHQ/selenium/pull/2137
[4] https://dxr.mozilla.org/mozilla-central/rev/16663eb3dcfa759f25b5e27b101bc79270c156f2/testing/marionette/driver.js#2508

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: MozReview Request: Bug 1274924 - GeckoDriver.getTextFromDialog() throws "TypeError: can't convert null to object" r=AutomatedTester

Review commit: https://reviewboard.mozilla.org/r/54580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54580/

Comment 2

[Johan Lorenzo [:jlorenzo]]

The following patch works for me locally. What would be the best place to add a test :AutomatedTester?

Comment 3

[David Burns :automatedtester]

Comment on attachment 8755382 [details]
MozReview Request: Bug 1274924 - GeckoDriver.getTextFromDialog() throws "TypeError: can't convert null to object" r=AutomatedTester

https://reviewboard.mozilla.org/r/54580/#review51196

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/370ee31f8d97

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/370ee31f8d97

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/52984371a7f0

Comment 7

[David Burns :automatedtester]

https://hg.mozilla.org/releases/mozilla-aurora/rev/52984371a7f0