Closed Bug 1274924 Opened 5 years ago Closed 5 years ago
Driver .get Text From Dialog() throws "Type Error: can't convert null to object"
MozReview Request: Bug 1274924 - GeckoDriver.getTextFromDialog() throws "TypeError: can't convert null to object" r=AutomatedTester
58 bytes, text/x-review-board-request
I don't have a reduced test case yet, but I can always repro this failure with this test. If I understand correctly, under a certain set of conditions, `this.dialog.ui` doesn't have a value yet. I proposed a workaround for the Selenium JS client at . I believe, we can just extend the if condition just above to make sure ui is not equal to null. I'll give it a try.  https://github.com/fxbox/foxbox/blob/42c347565b2cbdfd9f453b7b78b234effe841ee3/test/selenium/sessions_ui_test.js#L99 . Failed execution at: https://travis-ci.org/fxbox/foxbox/jobs/131700352#L1482  https://dxr.mozilla.org/mozilla-central/rev/16663eb3dcfa759f25b5e27b101bc79270c156f2/testing/marionette/driver.js#2513  https://github.com/SeleniumHQ/selenium/pull/2137  https://dxr.mozilla.org/mozilla-central/rev/16663eb3dcfa759f25b5e27b101bc79270c156f2/testing/marionette/driver.js#2508
Review commit: https://reviewboard.mozilla.org/r/54580/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54580/
Attachment #8755382 - Flags: review?(dburns)
The following patch works for me locally. What would be the best place to add a test :AutomatedTester?
Comment on attachment 8755382 [details] MozReview Request: Bug 1274924 - GeckoDriver.getTextFromDialog() throws "TypeError: can't convert null to object" r=AutomatedTester https://reviewboard.mozilla.org/r/54580/#review51196
Attachment #8755382 - Flags: review?(dburns) → review+
You need to log in before you can comment on or make changes to this bug.