Closed Bug 1274955 Opened 4 years ago Closed 4 years ago

Extract Android dependency versions

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(1 file)

I want to land some pieces from bug 1247047 independently. This bug is about extracting the dependency versions.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment on attachment 8755395 [details]
MozReview Request: Bug 1274955 - Extract Android dependency versions. r=glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54596/diff/1-2/
Comment on attachment 8755395 [details]
MozReview Request: Bug 1274955 - Extract Android dependency versions. r=glandium

https://reviewboard.mozilla.org/r/54596/#review51334

::: build.gradle:11
(Diff revision 2)
> +        buildToolsVersion = '23.0.1'
> +        googlePlayServicesVersion = '8.1.0'
> +        androidSupportLibraryVersion = '23.0.1'

there are ${variables} in build.gradle, that look like they come from the build system/configure. Can't these versions be pulled the same way?
Attachment #8755395 - Flags: review?(mh+mozilla)
Comment on attachment 8755395 [details]
MozReview Request: Bug 1274955 - Extract Android dependency versions. r=glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54596/diff/2-3/
Attachment #8755395 - Flags: review?(mh+mozilla)
Comment on attachment 8755395 [details]
MozReview Request: Bug 1274955 - Extract Android dependency versions. r=glandium

https://reviewboard.mozilla.org/r/54596/#review51622

::: build/autoconf/android.m4:211
(Diff revision 3)
>    MOZ_ANDROID_AAR_COMPONENT(concat(local_aar_var, _INTERNAL_LIB), concat(root, libs/$1-$2-internal_impl-$2.jar), $5)
>    MOZ_ANDROID_AAR_COMPONENT(concat(local_aar_var, _ASSETS), concat(root, assets), $6)
>  ])
>  
> +ANDROID_SUPPORT_LIBRARY_VERSION="23.0.1"
> +AC_DEFINE_UNQUOTED(ANDROID_SUPPORT_LIBRARY_VERSION,$ANDROID_SUPPORT_LIBRARY_VERSION)

you don't need this

::: build/autoconf/android.m4:215
(Diff revision 3)
> +ANDROID_SUPPORT_LIBRARY_VERSION="23.0.1"
> +AC_DEFINE_UNQUOTED(ANDROID_SUPPORT_LIBRARY_VERSION,$ANDROID_SUPPORT_LIBRARY_VERSION)
> +AC_SUBST(ANDROID_SUPPORT_LIBRARY_VERSION)
> +
> +ANDROID_GOOGLE_PLAY_SERVICES_VERSION="8.1.0"
> +AC_DEFINE_UNQUOTED(ANDROID_GOOGLE_PLAY_SERVICES_VERSION,$ANDROID_GOOGLE_PLAY_SERVICES_VERSION)

Likewise

::: build/autoconf/android.m4:346
(Diff revision 3)
>      ANDROID_TARGET_SDK="${android_target_sdk}"
>      ANDROID_SDK="${android_sdk}"
>      ANDROID_SDK_ROOT="${android_sdk_root}"
>      ANDROID_TOOLS="${android_tools}"
> -    AC_DEFINE_UNQUOTED(ANDROID_TARGET_SDK,$ANDROID_TARGET_SDK)
> +    ANDROID_BUILD_TOOLS_VERSION="$2"
> +    AC_DEFINE_UNQUOTED(ANDROID_TARGET_SDK,$ANDROID_TARGET_SDK,ANDROID_BUILD_TOOLS_VERSION)

That doesn't seem required.
Attachment #8755395 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8755395 [details]
MozReview Request: Bug 1274955 - Extract Android dependency versions. r=glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54596/diff/3-4/
Attachment #8755395 - Attachment description: MozReview Request: Bug 1274955 - Extract Android dependency versions. r?glandium → MozReview Request: Bug 1274955 - Extract Android dependency versions. r=glandium
https://hg.mozilla.org/mozilla-central/rev/6f8792420474
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 49 → mozilla49
You need to log in before you can comment on or make changes to this bug.