Open Bug 1275035 Opened 8 years ago Updated 2 years ago

Hard-limit key count & key length for keyed Histograms

Categories

(Toolkit :: Telemetry, defect, P4)

Product:
Toolkit
Component:
Telemetry
Type:
defect
Points:
2

Tracking

()

Tracking Flags:
Tracking Status
firefox49 --- affected

People

(Reporter: gfritzsche, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client]) 

Per bug 1275019, bug 1275010 et al we can have histograms slipping through the review process that bound the number of keys (or not properly).

We should hard-limit the number of keys per histogram to a fixed number and record this in a keyed histogram so we can identify the culprits.

While this doesn't solve the issue of many clients submitting distinct values, it at least reduces the impact on one side.
Similarly, we should hard-limit the length of the key strings (to avoid suffering from bugs and arbitrary key usage like bug 1275028).
Summary: Hard-limit key count for keyed Histograms → Hard-limit key count & key length for keyed Histograms
One important use-case for keys are addons. Those are restricted to 64 bytes:
https://github.com/mozilla/trunion/blob/master/trunion/validators.py#L171
Points: 1 → 2
Priority: P2 → P3
Priority: P3 → P4
Blocks: 1201022
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.