Remove confusing receiving codec data base from Video Conduit

RESOLVED FIXED in Firefox 50

Status

()

Core
WebRTC: Audio/Video
P3
normal
Rank:
35
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: drno, Assigned: drno)

Tracking

Trunk
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 affected, firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
In case of renegotiation the mRecvCodecList just keeps growing and spits out lots of confusing log messages.
(Assignee)

Comment 1

a year ago
Created attachment 8755628 [details]
Bug 1275119: remove mRecvCodecList from VideoConduit.

Review commit: https://reviewboard.mozilla.org/r/54702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54702/
Attachment #8755628 - Flags: review?(rjesup)
Attachment #8755628 - Flags: review?(docfaraday)
(Assignee)

Updated

a year ago
backlog: --- → webrtc/webaudio+
Rank: 35
Priority: -- → P3
Comment on attachment 8755628 [details]
Bug 1275119: remove mRecvCodecList from VideoConduit.

https://reviewboard.mozilla.org/r/54702/#review51360

It looks like this never provided any useful functionality, since the list of codecs configured lives in the webrtc.org code and the JSEP/etc code
Attachment #8755628 - Flags: review?(rjesup) → review+
(Assignee)

Updated

a year ago
Attachment #8755628 - Flags: review?(docfaraday)
(Assignee)

Comment 3

a year ago
Comment on attachment 8755628 [details]
Bug 1275119: remove mRecvCodecList from VideoConduit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54702/diff/1-2/
Attachment #8755628 - Flags: review?(docfaraday)
(Assignee)

Updated

a year ago
Attachment #8755628 - Flags: review?(docfaraday)
(Assignee)

Updated

a year ago
Depends on: 1275648
(Assignee)

Updated

a year ago
Depends on: 1273136
(Assignee)

Comment 4

a year ago
Comment on attachment 8755628 [details]
Bug 1275119: remove mRecvCodecList from VideoConduit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54702/diff/2-3/
Attachment #8755628 - Attachment description: MozReview Request: Bug 1275119: remove mRecvCodecList from VideoConduit. r=bwc,jesup → Bug 1275119: remove mRecvCodecList from VideoConduit.
(Assignee)

Comment 5

a year ago
Looks like either our testing code is shitty or we have some other ugly race conditions in our code now:

284 INFO Run step 41: PC_LOCAL_WAIT_FOR_MEDIA_FLOW
285 INFO Checking data flow to element: pcLocal_seek.webm_local_{41e53b46-9d1b-8b4c-8b12-6ab15a822563}
286 INFO Checking RTP packet flow for track {e98a5b69-f4ce-b840-bf64-28b7c909a337}
287 INFO Element pcLocal_seek.webm_local_{41e53b46-9d1b-8b4c-8b12-6ab15a822563} saw 'timeupdate', currentTime=0.966530612244898s, readyState=4
288 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | Media flowing for element: pcLocal_seek.webm_local_{41e53b46-9d1b-8b4c-8b12-6ab15a822563} 
289 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | Should have RTP stats for track {e98a5b69-f4ce-b840-bf64-28b7c909a337} 
290 INFO Track {e98a5b69-f4ce-b840-bf64-28b7c909a337} has 0 outboundrtp RTP packets.
291 INFO TEST-FAIL | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | The author of the test has indicated that flaky timeouts are expected.  Reason: WebRTC inherently depends on timeouts 
292 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | Should have RTP stats for track {e98a5b69-f4ce-b840-bf64-28b7c909a337} 
293 INFO Track {e98a5b69-f4ce-b840-bf64-28b7c909a337} has 0 outboundrtp RTP packets.
294 INFO TEST-FAIL | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | The author of the test has indicated that flaky timeouts are expected.  Reason: WebRTC inherently depends on timeouts 
295 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | Should have RTP stats for track {e98a5b69-f4ce-b840-bf64-28b7c909a337} 
296 INFO Track {e98a5b69-f4ce-b840-bf64-28b7c909a337} has 0 outboundrtp RTP packets.
297 INFO TEST-FAIL | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | The author of the test has indicated that flaky timeouts are expected.  Reason: WebRTC inherently depends on timeouts 
298 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | Should have RTP stats for track {e98a5b69-f4ce-b840-bf64-28b7c909a337} 
299 INFO Track {e98a5b69-f4ce-b840-bf64-28b7c909a337} has 0 outboundrtp RTP packets.
300 INFO TEST-FAIL | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | The author of the test has indicated that flaky timeouts are expected.  Reason: WebRTC inherently depends on timeouts 
301 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | Should have RTP stats for track {e98a5b69-f4ce-b840-bf64-28b7c909a337} 
302 INFO Track {e98a5b69-f4ce-b840-bf64-28b7c909a337} has 0 outboundrtp RTP packets.
303 INFO TEST-FAIL | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | The author of the test has indicated that flaky timeouts are expected.  Reason: WebRTC inherently depends on timeouts 
304 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | Should have RTP stats for track {e98a5b69-f4ce-b840-bf64-28b7c909a337} 
305 INFO Track {e98a5b69-f4ce-b840-bf64-28b7c909a337} has 6 outboundrtp RTP packets.
306 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | RTP flowing for track {e98a5b69-f4ce-b840-bf64-28b7c909a337} 
307 INFO Run step 42: PC_REMOTE_WAIT_FOR_MEDIA_FLOW
308 INFO Checking data flow to element: pcRemote_seek.webm_remote_{41e53b46-9d1b-8b4c-8b12-6ab15a822563}
309 INFO Checking RTP packet flow for track {e98a5b69-f4ce-b840-bf64-28b7c909a337}
310 INFO TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | Should have RTP stats for track {e98a5b69-f4ce-b840-bf64-28b7c909a337} 
    waitForRtpFlow/hasFlow@dom/media/tests/mochitest/pc.js:1431:7
    waitForRtpFlow/retry/<@dom/media/tests/mochitest/pc.js:1445:22
    promise callback*waitForRtpFlow/retry@dom/media/tests/mochitest/pc.js:1444:23
    waitForRtpFlow@dom/media/tests/mochitest/pc.js:1447:12
    PeerConnectionWrapper.prototype.waitForMediaFlow/<@dom/media/tests/mochitest/pc.js:1462:47
    PeerConnectionWrapper.prototype.waitForMediaFlow@dom/media/tests/mochitest/pc.js:1462:7
    PC_REMOTE_WAIT_FOR_MEDIA_FLOW@dom/media/tests/mochitest/templates.js:422:12
    CommandChain.prototype.execute/</<@dom/media/tests/mochitest/head.js:623:31
    promise callback*CommandChain.prototype.execute/<@dom/media/tests/mochitest/head.js:621:14
    CommandChain.prototype.execute@dom/media/tests/mochitest/head.js:616:12
    startTest/</<@dom/media/tests/mochitest/test_peerConnection_capturedVideo.html:68:14
    runNetworkTest/</</<@dom/media/tests/mochitest/pc.js:1882:21
    promise callback*runNetworkTest/</<@dom/media/tests/mochitest/pc.js:1880:7
    runTestWhenReady/<@dom/media/tests/mochitest/head.js:349:41
    promise callback*runTestWhenReady@dom/media/tests/mochitest/head.js:349:10
    runNetworkTest/<@dom/media/tests/mochitest/pc.js:1879:5
    promise callback*runNetworkTest@dom/media/tests/mochitest/pc.js:1878:10
    startTest/<@dom/media/tests/mochitest/test_peerConnection_capturedVideo.html:53:12
    promise callback*startTest@dom/media/tests/mochitest/test_peerConnection_capturedVideo.html:45:3
    MediaTestManager/this.nextTest@dom/media/test/manifest.js:1580:7
    MediaTestManager/this.runTests/<@dom/media/test/manifest.js:1517:7
(Assignee)

Comment 6

a year ago
Comment on attachment 8755628 [details]
Bug 1275119: remove mRecvCodecList from VideoConduit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54702/diff/3-4/
(Assignee)

Comment 7

a year ago
Comment on attachment 8755628 [details]
Bug 1275119: remove mRecvCodecList from VideoConduit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54702/diff/4-5/

Comment 8

a year ago
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/c61101c15a28
remove mRecvCodecList from VideoConduit. r=jesup
https://hg.mozilla.org/mozilla-central/rev/c61101c15a28
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.