1275306 - Use more TimeDuration and TimeStamp in the shell

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: use_timeduration_for_MAX_TIMEOUT_INTERVAL-v0.diff

Here are two more pieces of the puzzle. They do not block the ConditionVariable patch directly, but they're a nice cleanup that I'd like to see landed. The first patch here replaces MAX_TIMEOUT_INTERVAL with a TimeDuration. The second replaces watchdog[Has]Timeout with a Maybe<TimeStamp>.

Comment 1

[Terrence Cole [:terrence]]

Attachment: use_TimeStamp_for_watchdogTimeout-v0.diff

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8755910 [details] [diff] [review]
use_timeduration_for_MAX_TIMEOUT_INTERVAL-v0.diff

Review of attachment 8755910 [details] [diff] [review]:
-----------------------------------------------------------------

Much more readable.

::: js/src/shell/js.cpp
@@ +3099,3 @@
>  
>          /* NB: The next condition also filter out NaNs. */
> +        if (duration > MAX_TIMEOUT_INTERVAL) {

This comment about filtering NaN no longer applies right? What will we do for NaN now, does TimeDuration check for it?

@@ +3286,5 @@
>  static bool
>  SetTimeoutValue(JSContext* cx, double t)
>  {
>      /* NB: The next condition also filter out NaNs. */
> +    if (TimeDuration::FromSeconds(t) > MAX_TIMEOUT_INTERVAL) {

Same here.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8755911 [details] [diff] [review]
use_TimeStamp_for_watchdogTimeout-v0.diff

Review of attachment 8755911 [details] [diff] [review]:
-----------------------------------------------------------------

Splendid.

Comment 4

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b12fe0ea05d6669181144ad17652cc0d92a81de8
Bug 1275306 - Part 1: Use TimeDuration for MAX_TIMEOUT_INTERVAL in the JS shell; r=jandem

https://hg.mozilla.org/integration/mozilla-inbound/rev/4942b307cf4a1784168dd7a6d167a0c7a62c6790
Bug 1275306 - Part 2: Use a TimeStamp to implement watchdogTimeout; r=jandem

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for likely causing intermittent crashes in 13.3.0_7.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0667549f62c0b41938ec448951e1b476ea7e88f5
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa26a17137868e2d72a98b294398940855ae8ad

The backout of bug 956899 was insufficient.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d58e8b384d3e
https://hg.mozilla.org/integration/mozilla-inbound/rev/10a2a0ed4d32

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Relanded the patches because the issue with jsreftests persisted after the backouts.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d58e8b384d3e
https://hg.mozilla.org/mozilla-central/rev/10a2a0ed4d32