1275357 - MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET can get cached, leading to invalid build output

Status: NEW

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Currently, we AC_SUBST MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET in old-configure.in. If these are set in environment variables, the subst variables get set. In variables.py, we look at subst for these values.

If you set MOZ_SOURCE_REPO, run configure, then unset MOZ_SOURCE_REPO (or MOZ_SOURCE_CHANGESET), the cached values are used.

This just caused bustage on inbound when landing bug 1274655. I landed a change to mozharness to set MOZ_SOURCE_REPO. This made variables.py raise. So I backed out. However, subsequent builds still raised the same exception because configure didn't run and MOZ_SOURCE_REPO was cached in subst for variables.py to use. A clobber was required to fix.

Comment 1

[Mike Hommey [:glandium]]

That's true of any AC_SUBST that comes from the environment, and that can't be fixed without running configure every time.