44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Looking at https://www.mozilla.org/firefox/products/, the footer looks incomplete. At least the language selector is missing, but I think we also want the licensing info, and all the other links. Might be a regression from bug 1213372, but that’s just a guess.
This page was intentionally designed with a minimal footer, but perhaps it's a little *too* minimal. I think we should at least add the language switcher but probably not do the full standard footer on this page (with all the social media etc).
Component: Bedrock → Pages & Content
I'm guessing we lost the language selector as a regression, so let's add that back in. And Craig is right, this is supposed to be a minimal footer. The minimum links are there working as expected, so let's just add the language switcher back on. Thanks!
Created attachment 8760497 [details] [review] Github pull request https://github.com/mozilla/bedrock/pull/4176
Assignee: nobody → craigcook.bugz
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/513d9bce754da14a735e77437b0f42152f0811ff [fix bug 1275431] Add language switcher to product page footer https://github.com/mozilla/bedrock/commit/d31e39f955514b5d63ef889bc33ac2afd9b39d8a Merge pull request #4176 from craigcook/bug-1275431-products-footer-lang-switcher [fix bug 1275431] Add language switcher to product page footer
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.