1275452 - support anonymous content styling in stylo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Part 1: Add Servo_RestyleSubtree for eagerly restyling a subtree of a document.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Part 2: Eagerly restyle native anonymous content in stylo.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Part 3: Eagerly restyle XBL-provided anonymous content in stylo.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Part 4: Remove anonymous content styling hack in ServoStyleSet.

Comment 5

[Cameron McCormack (:heycam)]

See also: https://github.com/servo/servo/pull/11404

Comment 6

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e174bb788abb

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8756169 [details] [diff] [review]
Part 1: Add Servo_RestyleSubtree for eagerly restyling a subtree of a document.

Review of attachment 8756169 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/ServoStyleSet.h
@@ +51,5 @@
>  
>    void BeginUpdate();
>    nsresult EndUpdate();
>  
> +  void ForceRestyle(nsINode* aNode);

I don't particularly like the use of "Force" here. To me that implies that we're throwing away cached data and restyling everything, which isn't going to be what we do here long-term. So maybe just call this RestyleSubtree?

Comment 8

[Bobby Holley (:bholley)]

Comment on attachment 8756170 [details] [diff] [review]
Part 2: Eagerly restyle native anonymous content in stylo.

Review of attachment 8756170 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know my way around the frame constructor well enough to say with certainty that this is the right place to do it, but seems harmless enough.

Comment 9

[Bobby Holley (:bholley)]

Comment on attachment 8756172 [details] [diff] [review]
Part 4: Remove anonymous content styling hack in ServoStyleSet.

Review of attachment 8756172 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a51e41ec23e2
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce7e41b72c76
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e15a686b21e
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcf1684b63b3

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a51e41ec23e2
https://hg.mozilla.org/mozilla-central/rev/ce7e41b72c76
https://hg.mozilla.org/mozilla-central/rev/5e15a686b21e
https://hg.mozilla.org/mozilla-central/rev/dcf1684b63b3