Closed Bug 1275492 Opened 4 years ago Closed 3 years ago

[webvtt] Add logs for TextTrackManager/TextTrack* .

Categories

(Core :: Audio/Video: Playback, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: bechen, Assigned: bechen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Mass change P2 -> P3
Priority: P2 → P3
Blocks: webvtt
No longer depends on: webvtt
Priority: P3 → P5
Assignee: nobody → bechen
Comment on attachment 8782368 [details]
Bug 1275492 - Add logs for TextTrackManager.

https://reviewboard.mozilla.org/r/72550/#review70202

::: dom/html/TextTrackManager.cpp:27
(Diff revision 1)
>  
>  namespace mozilla {
>  namespace dom {
>  
> +static mozilla::LazyLogModule gTextTrackLog("TextTrackManager");
> +#define LOG(type, msg) MOZ_LOG(gTextTrackLog, type, msg)

It is more concise to define:
#define LOG(...)  MOZ_LOG(gTextTrackLog, LogLevel::Debug,   (__VA_ARGS__))
#define LOGV(...) MOZ_LOG(gTextTrackLog, LogLevel::Verbose, (__VA_ARGS__))
Attachment #8782368 - Flags: review?(jwwang) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/11e3d323e336
Add logs for TextTrackManager. r=jwwang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/11e3d323e336
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.