1275492 - [webvtt] Add logs for TextTrackManager/TextTrack* .

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3

Comment 2

[Benjamin Chen [:bechen]]

Attachment: Bug 1275492 - Add logs for TextTrackManager.

Review commit: https://reviewboard.mozilla.org/r/72550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72550/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8782368 [details]
Bug 1275492 - Add logs for TextTrackManager.

https://reviewboard.mozilla.org/r/72550/#review70202

::: dom/html/TextTrackManager.cpp:27
(Diff revision 1)
>  
>  namespace mozilla {
>  namespace dom {
>  
> +static mozilla::LazyLogModule gTextTrackLog("TextTrackManager");
> +#define LOG(type, msg) MOZ_LOG(gTextTrackLog, type, msg)

It is more concise to define:
#define LOG(...)  MOZ_LOG(gTextTrackLog, LogLevel::Debug,   (__VA_ARGS__))
#define LOGV(...) MOZ_LOG(gTextTrackLog, LogLevel::Verbose, (__VA_ARGS__))

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8782368 [details]
Bug 1275492 - Add logs for TextTrackManager.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72550/diff/1-2/

Comment 5

[Benjamin Chen [:bechen]]

Comment on attachment 8782368 [details]
Bug 1275492 - Add logs for TextTrackManager.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72550/diff/2-3/

Comment 6

[Benjamin Chen [:bechen]]

Comment on attachment 8782368 [details]
Bug 1275492 - Add logs for TextTrackManager.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72550/diff/3-4/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11e3d323e336
Add logs for TextTrackManager. r=jwwang

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11e3d323e336