1275590 - view_job_queue.cgi fails with Oracle due to invalid SQL query

Status: NEW

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Frédéric Buclin]

An error occurred while performing a database operation:

DBD::Oracle::db selectall_arrayref failed: ORA-25155: column used in NATURAL join cannot have qualifier

at Bugzilla/DB.pm line 148.
	Bugzilla::DB::_handle_error(...) called at Bugzilla/DB/Oracle.pm line 435
	Bugzilla::DB::Oracle::selectall_arrayref(...) called at /var/www/html/bugzilla/view_job_queue.cgi line 69
	main::generate_report(...) called at /var/www/html/bugzilla/view_job_queue.cgi line 29

Comment 1

[Dylan Hardison [:dylan] (he/him)]

https://github.com/bugzilla/bugzilla/blob/master/view_job_queue.cgi#L58-L62 is the culprit.

Seems like we delete the word NATURAL and add " ON j.jobid = t.jobid"
something like?

             NATURAL LEFT JOIN (
                SELECT MAX(error_time) AS error_time, jobid
                  FROM ts_error
                 GROUP BY jobid
            ) t ON j.jobid = t.jobid

Comment 2

[Dylan Hardison [:dylan] (he/him)]

err, without NATURAL

Comment 3

[Dylan Hardison [:dylan] (he/him)]

I can't allocate resources to this right now, but it is important. P3 makes sense