1275630 - Update documentation links

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Ralph Giles (:rillian)]

The breakpad code references docs on Google Code which is not longer an active site.

Comment 1

[Ralph Giles (:rillian)]

Attachment: MozReview Request: Bug 1275630 - Update breakpad documentation links. r?ted

These locations have changed since the end of Google Code.

Review commit: https://reviewboard.mozilla.org/r/55176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55176/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8756439 [details]
MozReview Request: Bug 1275630 - Update breakpad documentation links. r?ted

https://reviewboard.mozilla.org/r/55176/#review51866

::: toolkit/crashreporter/google-breakpad/README.ANDROID:61
(Diff revision 1)
>  
>  II. Using the client library in Android:
>  ========================================
>  
>  The usage instructions are very similar to the Linux ones that are
> -found at http://code.google.com/p/google-breakpad/wiki/LinuxStarterGuide
> +found at https://chromium.googlesource.com/breakpad/breakpad/+/master/docs/linux_starter_guide.md

Everything under google-breakpad is upstream code, so if we don't patch this upstream it'll just get overwritten the next time I update from upstream.

If you give me a patch against upstream for these files I can land it for you.

Comment 3

[Ralph Giles (:rillian)]

Attachment: Upstream patch

Here's a patch against upstream, except for the fix_stack_using_bpsyms.py hunk. I think that firefox-specific code, and still needs to land on our side.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8757003 [details] [diff] [review]
Upstream patch

Landed upstream, thanks!
https://chromium.googlesource.com/breakpad/breakpad/+/c65ed6573eb34a5bbfe13b6bd2e7f70cdd2ed541

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8756439 [details]
MozReview Request: Bug 1275630 - Update breakpad documentation links. r?ted

https://reviewboard.mozilla.org/r/55176/#review55836

Feel free to land this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e076bb03ff4
Update breakpad documentation links. r=ted

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e076bb03ff4