1275659 - Update tooltool rustc to 1.9

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Rust 1.9.0 stable should be out tomorrow. We should update our official builds to use it.

For 1.8 I used repacks of the upstream builds, but it looks like we want to build the standard library with --enable-debuginfo and possibly panic=abort, so it's back to custom builds for this. Please update the scripts at https://github.com/rillian/rust-build as necessary.

Comment 1

[Ralph Giles (:rillian)]

Thanks for offering to look at this, Nathan. Note that Mac may or may not work because of the eh_personality thing. See bug 1269808.

Comment 2

[Ralph Giles (:rillian)]

I did a test build of 1.9.0 with --enable-debuginfo for linux.

[
{
"version": "gecko rust 1.9.0 (commit e4e8b666850a763fdf1c3c2c142856ab51e32779)",
"algorithm": "sha512",
"visibility": "public",
"filename": "rustc.tar.xz",
"unpack": true,
"digest": "d613d5528e83bb73917372948c05a766912a9dd0ec4e8a5fab69161a515c1545d52e9ed3394716df96a9dcdf1c086b6f970413e97c2df78a11e5f9151573921a",
"size": 96854912
}
]

Comment 3

[Ralph Giles (:rillian)]

Same for mac.

[
{
"version": "rustc 1.9.0-dev gecko build with debuginfo (e4e8b6668 2016-05-18)",
"algorithm": "sha512",
"visibility": "public",
"filename": "rustc.tar.bz2",
"unpack": true,
"digest": "65d206d7ad0bd660c2c88f732d80c417e9da02bf57db6e17467b6e4ac2acf2e538ccaef50a0a65ed446b63ce63dc307a48e978e7f6c8ca2a482f8bbc31b006b4",
"size": 122293979
}
]

Comment 4

[Ralph Giles (:rillian)]

Previous build was targetting mac 10.9. I forgot we still build on 10.7. Here's a build with --enable-debuginfo and MACOSX_DEPLOYMENT_TARGET=10.7.

{
"version": "rustc 1.9.0-dev gecko build with debuginfo (e4e8b6668 2016-05-18)",
"algorithm": "sha512",
"visibility": "public",
"filename": "rustc.tar.bz2",
"unpack": true,
"digest": "67124e8b5311e694da138b3bbf4f77ddde888829fa6aa0a94ef5f28fe807d4ca4f42818a36b28a1f4f2388be53e3ac6ad0d51f32e5425b39c3bb612aec83f583",
"size": 122416001
}

It reproduces bug 1188030 just like the upstream rust 1.8.0 build in bug 1269808, so it looks like Mac is still stuck on rust 1.6.

20:28:33     INFO -  ld: warning: could not create compact unwind for _ffi_call_unix64: does not use RBP or RSP based frame
20:28:33     INFO -  ld: warning: too many personality routines for compact unwind to encode
20:28:33     INFO -  Assertion failed: (_mode == modeFinalAddress), function finalAddress, file /SourceCache/ld64/ld64-123.2.1/src/ld/ld.hpp, line 573.
20:28:33     INFO -  0  0x10bbcd71c  __assert_rtn + 76
20:28:33     INFO -  1  0x10bc4601c  ld::tool::OutputFile::addressOf(ld::Internal const&, ld::Fixup const*, ld::Atom const**) + 172
20:28:33     INFO -  2  0x10bc48a25  ld::tool::OutputFile::applyFixUps(ld::Internal&, unsigned long long, ld::Atom const*, unsigned char*) + 3909
20:28:33     INFO -  3  0x10bc44f70  ld::tool::OutputFile::writeOutputFile(ld::Internal&) + 816
20:28:33     INFO -  4  0x10bc3dab9  ld::tool::OutputFile::write(ld::Internal&) + 153
20:28:33     INFO -  5  0x10bbcdcaa  main + 1178
20:28:33     INFO -  6  0x10bbbc2b4  start + 52
20:28:33     INFO -  clang-3.8: error: linker command failed with exit code 1 (use -v to see invocation)
20:28:33     INFO -  make[5]: *** [XUL] Error 1

Comment 5

[Mike Hommey [:glandium]]

Presumably these issues will go away when builders are updated to something more recent to 10.7, as they should get a new version of ld64 at the time, which, I assume would fix those issues.

Comment 6

[Ralph Giles (:rillian)]

(In reply to Mike Hommey [:glandium] from comment #5)

> Presumably these issues will go away when builders are updated to something
> more recent to 10.7, as they should get a new version of ld64 at the time,
> which, I assume would fix those issues.

Hopefully. I have linking trouble on my local mac too (os 10.10.5, Xcode 7.2.1), but the resolution of bug 1269798 was to wait for the tc cross jobs to become tier-1 and we haven't seen the linking issue there. I also hope building with `-C panic=abort` (rust 1.10 and later) will fix this.

Comment 7

[Ralph Giles (:rillian)]

Attachment: MozReview Request: Bug 1275659 - Update windows tooltool rust to 1.9.0. r?mshal

Repacked official binaries of the 1.9.0 stable release and std library.

Review commit: https://reviewboard.mozilla.org/r/56434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56434/

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8758052 [details]
MozReview Request: Bug 1275659 - Update windows tooltool rust to 1.9.0. r?mshal

Landed under bug 1276747 to keep this one open for tracking.

https://hg.mozilla.org/integration/mozilla-inbound/rev/26187322aa05

Comment 9

[Ralph Giles (:rillian)]

https://hg.mozilla.org/mozilla-central/rev/47c611b9a71b

Comment 10

[Guilherme Lima]

Shouldn't this get marked as fixed? You already landed 1.10!

Comment 11

[Gregory Szorc [:gps]]

(In reply to Guilherme Lima from comment #10)
> Shouldn't this get marked as fixed? You already landed 1.10!

Yes. I'm not sure what happened here. But this bug is obviously obsolete.