1275703 - AEC is off in second and later getUserMedia() calls

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1, critical)

Description

[Randell Jesup [:jesup] (needinfo me)]

After starting and stopping a getUserMedia audio capture, on the next getUserMedia call the AEC (and NS/AGC) will all be off, because we release the VoiceEngine but don't clear our copy of the state of the engine.

This patch removes the copy of the state entirely.  Researching shows that this ends up in ProcessingComponent::EnableComponent(bool enable), which does "if (enable && !enabled_)", so re-enabling has no effect - thus our paranoia about re-enabling resetting the AEC is unfounded.

This was caused by bug 1273206

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: remove saved state about configuration of the VoiceEngine

MozReview-Commit-ID: CyOhSa3dOSU

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8756518 [details] [diff] [review]
remove saved state about configuration of the VoiceEngine

Review of attachment 8756518 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, though mEchoCancel, mAGC and mNoiseSuppress appear unused, and can be removed as well AFAICT. That should simplify further.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: remove the rest of the saved state

MozReview-Commit-ID: 1e86oZWUGeq

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8756551 [details] [diff] [review]
remove the rest of the saved state

Review of attachment 8756551 [details] [diff] [review]:
-----------------------------------------------------------------

Less is more.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eff54d521d78

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eff54d521d78