1275706 - Tune eslint max line length to 90

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Brian Grinstead [:bgrins]]

Based on the discussion in https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/zcWUzmbY2N0, we should relax the line length requirement for eslint a bit which will result in less required changes.

It's currently 80.  100 and 90 were mentioned so I'd suggest we go with 90 since it's closer to the current value.

Comment 1

[Brian Grinstead [:bgrins]]

Switching to 90 takes the output of './mach eslint --no-ignore devtools' from:

303956 problems (282923 errors, 21033 warnings)

to:

297055 problems (276022 errors, 21033 warnings)

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1275706 - Tune eslint max line length to 90;r=jryans

Review commit: https://reviewboard.mozilla.org/r/55210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55210/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8756525 [details]
MozReview Request: Bug 1275706 - Tune eslint max line length to 90;r=jryans

https://reviewboard.mozilla.org/r/55210/#review51920

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8dfd7c9d8639

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8dfd7c9d8639