Open Bug 1275775 Opened 9 years ago Updated 3 years ago

Remove most spidermonkey builds, add osx builds for greening

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
ASSIGNED

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file)

Remove most spidermonkey builds, add osx builds for greening
6.41 KB, patch
bhearsum
: review+
Details | Diff | Splinter Review
glandium noticed that we don't have any osx spidermonkey builds anymore. And I noticed that we have some extra buildbot builds that we don't need now.
bhearsum: do you remember if there's a reason we don't have osx spidermonkey jobs? Are we heavily resource-constrained on osx machines?
Attachment #8756622 - Flags: review?(bhearsum)
Blocks: 975466
Are we no longer having SpiderMonkey jobs permanently? This seems undesirable, we should have them to prevent build failures. If not, we should have a follow-up bug to re-add them.
All the ones we care about are running on Taskcluster now.
> All the ones we care about are running on Taskcluster now. I meant for fuzzing. Previously we had lots of fuzzblockers due to build failures. When they ended up on treeherder our issues were solved as it ensured builds could not be broken. If they are no longer on treeherder, they should probably still be, or else there will be build failures as fuzzblockers again. Steve, thoughts?
Flags: needinfo?(sphink)
(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #4) > > All the ones we care about are running on Taskcluster now. > > I meant for fuzzing. Previously we had lots of fuzzblockers due to build > failures. When they ended up on treeherder our issues were solved as it > ensured builds could not be broken. If they are no longer on treeherder, > they should probably still be, or else there will be build failures as > fuzzblockers again. > > Steve, thoughts? I'm not sure what you mean. The builds should all still be there, just many of them are now running under taskcluster instead of buildbot. If any builds have been lost, then it's a bug, and I'd like to know. arm64 was mistakenly not scheduled; RyanVM just fixed that. The SM(e) builds are now redundant with SM(p) and have been removed or will be removed by the patch in this bug. I don't think you ever used any of the actual binaries built by these jobs for your fuzzing. (They are still getting produced, but you have to get to them differently.)
Flags: needinfo?(sphink)
> If any builds have been lost, then it's a bug, and I'd like to know. > > arm64 was mistakenly not scheduled; RyanVM just fixed that. ARM64 was exactly the build that me and RyanVM spoke about on IRC, which was fixed as you mentioned (in bug 1275792). > I don't think you ever used any of the actual binaries built by these jobs > for your fuzzing. True, though the purpose of these builds were to ensure that things didn't break when built. That said, the builds that are used tend to be on archive.m.o, e.g.: https://archive.mozilla.org/pub/firefox/nightly/2016/05/2016-05-25-06-37-10-mozilla-central/jsshell-win64.zip Thanks for following up! I believe the concerns have been addressed.
Attachment #8756622 - Flags: review?(bhearsum) → review+
(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #6) > True, though the purpose of these builds were to ensure that things didn't > break when built. Yes, so we shouldn't lose any of that coverage unless I mess up. > That said, the builds that are used tend to be on > archive.m.o, e.g.: > > https://archive.mozilla.org/pub/firefox/nightly/2016/05/2016-05-25-06-37-10- > mozilla-central/jsshell-win64.zip Those are from the firefox builds, not the SM builds. They haven't changed.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: