Closed Bug 1275783 Opened 4 years ago Closed 4 years ago

Use "branch" instead of "revision" with MercurialVCS

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
Tracking Status
firefox49 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(4 files)

+++ This bug was initially created as a clone of Bug #1274092 +++

There are still a number of callers that specify "revision": "default" and will break. This includes release day scripts.
The normal MercurialVCS now supports querying pushlog. Use it.

This isn't really relevant to the bug summary and other commits in this
series. But I already wrote this commit and was too lazy to create a
new bug for it.

Review commit: https://reviewboard.mozilla.org/r/55312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55312/
Attachment #8756646 - Flags: review?(jlund)
Attachment #8756647 - Flags: review?(jlund)
Attachment #8756648 - Flags: review?(jlund)
Attachment #8756649 - Flags: review?(jlund)
I /think/ hazard builds are currently only performed on TC, which doesn't
use the VCS settings in mozharness. So I don't think this could possibly
break automation.

While I was here, I removed a reference to hgtool since we're no longer
using hgtool in this job.

Review commit: https://reviewboard.mozilla.org/r/55314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55314/
I'm pretty sure partner repacks are using the modern HgVCS and not
HgToolVCS. So have them use "branch" instead of "revision" for symbolic
revisions.

Review commit: https://reviewboard.mozilla.org/r/55316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55316/
These all definitely use the modern HgVCS because it is explicitly
specified in the configs. So without this change, these configs would
fail since --revision rejects symbolic names.

Review commit: https://reviewboard.mozilla.org/r/55318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55318/
Comment on attachment 8756647 [details]
MozReview Request: Bug 1275783 - Specify "branch" instead of "revision" in hazard config; r?jlund

https://reviewboard.mozilla.org/r/55314/#review52084
Attachment #8756647 - Flags: review?(jlund) → review+
Comment on attachment 8756648 [details]
MozReview Request: Bug 1275783 - Specify "branch" instead of "revision" in partner repacks; r?jlund

https://reviewboard.mozilla.org/r/55316/#review52086
Attachment #8756648 - Flags: review?(jlund) → review+
Comment on attachment 8756649 [details]
MozReview Request: Bug 1275783 - Use "branch" instead of "revision" in release configs; r?jlund

https://reviewboard.mozilla.org/r/55318/#review52088
Attachment #8756649 - Flags: review?(jlund) → review+
Comment on attachment 8756646 [details]
MozReview Request: Bug 1275783 - Don't use HgtoolVCS to query pushlog; r?jlund

https://reviewboard.mozilla.org/r/55312/#review52090
Attachment #8756646 - Flags: review?(jlund) → review+
You need to log in before you can comment on or make changes to this bug.