1275783 - Use "branch" instead of "revision" with MercurialVCS

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Gregory Szorc [:gps]]

+++ This bug was initially created as a clone of Bug #1274092 +++

There are still a number of callers that specify "revision": "default" and will break. This includes release day scripts.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1275783 - Don't use HgtoolVCS to query pushlog; r?jlund

The normal MercurialVCS now supports querying pushlog. Use it.

This isn't really relevant to the bug summary and other commits in this
series. But I already wrote this commit and was too lazy to create a
new bug for it.

Review commit: https://reviewboard.mozilla.org/r/55312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55312/

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1275783 - Specify "branch" instead of "revision" in hazard config; r?jlund

I /think/ hazard builds are currently only performed on TC, which doesn't
use the VCS settings in mozharness. So I don't think this could possibly
break automation.

While I was here, I removed a reference to hgtool since we're no longer
using hgtool in this job.

Review commit: https://reviewboard.mozilla.org/r/55314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55314/

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1275783 - Specify "branch" instead of "revision" in partner repacks; r?jlund

I'm pretty sure partner repacks are using the modern HgVCS and not
HgToolVCS. So have them use "branch" instead of "revision" for symbolic
revisions.

Review commit: https://reviewboard.mozilla.org/r/55316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55316/

Comment 4

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1275783 - Use "branch" instead of "revision" in release configs; r?jlund

These all definitely use the modern HgVCS because it is explicitly
specified in the configs. So without this change, these configs would
fail since --revision rejects symbolic names.

Review commit: https://reviewboard.mozilla.org/r/55318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55318/

Comment 5

[Jordan Lund (:jlund)]

Comment on attachment 8756647 [details]
MozReview Request: Bug 1275783 - Specify "branch" instead of "revision" in hazard config; r?jlund

https://reviewboard.mozilla.org/r/55314/#review52084

Comment 6

[Jordan Lund (:jlund)]

Comment on attachment 8756648 [details]
MozReview Request: Bug 1275783 - Specify "branch" instead of "revision" in partner repacks; r?jlund

https://reviewboard.mozilla.org/r/55316/#review52086

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8756649 [details]
MozReview Request: Bug 1275783 - Use "branch" instead of "revision" in release configs; r?jlund

https://reviewboard.mozilla.org/r/55318/#review52088

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8756646 [details]
MozReview Request: Bug 1275783 - Don't use HgtoolVCS to query pushlog; r?jlund

https://reviewboard.mozilla.org/r/55312/#review52090

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/266983e52332
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3aeacd99375
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0240db65768
https://hg.mozilla.org/integration/mozilla-inbound/rev/126a5b8a2761

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/266983e52332
https://hg.mozilla.org/mozilla-central/rev/c3aeacd99375
https://hg.mozilla.org/mozilla-central/rev/f0240db65768
https://hg.mozilla.org/mozilla-central/rev/126a5b8a2761