1275863 - test test_peerConnection_addTrack.html fails on Autophone

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Dan Minor [:dminor]]

This appears to be a regression. The last good revision was [1] and the first bad is [2] and it has failed since then. A starting point for investigation would be Bug 1271669 which appears to touch related code and landed as part of this merge.

Autophone is available on try with the following syntax:

try: -b o -p android-api-9,android-api-15 -u autophone-mochitest-webrtc -t none

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=46fe2115d46a5bb40523b8466341d8f9a26e1bdf&filter-tier=1&filter-tier=2&filter-tier=3
[2] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=829d3be6ba648b838ee1953fdfa1a477dace752f&filter-tier=1&filter-tier=2&filter-tier=3

Comment 1

[Dan Minor [:dminor]]

When I disabled test_peerConnection_addSecondVideoStreamNoBundle.html, the test before it in the manifest began crashing. It turns out the problem was the test after it in the manifest, which is test_peerConnection_addTrack.html, and whatever test executed prior to it was blamed for the crash.

Comment 2

[Bob Clary [:bc] (inactive)]

dminor: This is really a timeout with a forced SIGBART ?

Comment 3

[Dan Minor [:dminor]]

(In reply to Bob Clary [:bc:] from comment #2)
> dminor: This is really a timeout with a forced SIGBART ?

Yes, sorry.

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1275863 - Remove test_peerConnection_addTrack.html from autophone webrtc manifest;

This test was removed as part of commit 2a7dbc0411d1, but we still try to run
it.

Review commit: https://reviewboard.mozilla.org/r/57676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57676/

Comment 5

[Bob Clary [:bc] (inactive)]

Comment on attachment 8759813 [details]
Bug 1275863 - Remove test_peerConnection_addTrack.html from autophone webrtc manifest;

https://reviewboard.mozilla.org/r/57676/#review54518

great. looking forward to less orange.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90c14ea7e707
Remove test_peerConnection_addTrack.html from autophone webrtc manifest; r=bc

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/90c14ea7e707

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like this would have landed just after the merge. Should the test fix be uplifted to aurora 49?

Comment 9

[Dan Minor [:dminor]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #8)
> Looks like this would have landed just after the merge. Should the test fix
> be uplifted to aurora 49?

We only run autophone tests on mozilla-central and try at the moment so we don't need an uplift now, but if we expand our coverage in the future it would be nice to have.

Comment 10

[Dan Minor [:dminor]]

Comment on attachment 8759813 [details]
Bug 1275863 - Remove test_peerConnection_addTrack.html from autophone webrtc manifest;

Approval Request Comment
[Feature/regressing bug #]: This test was removed from the standard mochitest manifests in a commit in 49, but we didn't remove it from the autophone manifests until 50.
[User impact if declined]: None, test only.
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]:  None. We don't currently run Autophone on aurora, but if we expand our coverage, it would be nice to have this fix in place.
[String/UUID change made/needed]: None.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8759813 [details]
Bug 1275863 - Remove test_peerConnection_addTrack.html from autophone webrtc manifest;

Extra test coverage for aurora, ok to uplift.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a720069003b6