1275901 - Update in-tree libpng to version 1.6.23

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Glenn Randers-Pehrson]

Libpng-1.6.22 was released on 26 May 2016.

Comment 1

[Glenn Randers-Pehrson]

Attachment: V00 update embedded libpng to version 1.6.22

Ready for try

Comment 2

[Ryan VanderMeulen [:RyanVM]]

applying v00-1275901-libpng-1.6.22.diff
unable to find 'media/libpng/sse/filter_sse2_intrinsics.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/sse/filter_sse2_intrinsics.c.rej
unable to find 'media/libpng/sse/intel_init.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/sse/intel_init.c.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh v00-1275901-libpng-1.6.22.diff

Comment 3

[Glenn Randers-Pehrson]

Attachment: V01 update embedded libpng to version 1.6.22

I'll separate out the new SSE support into another bug.

Comment 4

[Glenn Randers-Pehrson]

Please "try" the v01 patch

Comment 5

[Ryan VanderMeulen [:RyanVM]]

applying v01-1275901-libpng-1.6.22.diff
patching file media/libpng/apng.patch
Hunk #1 FAILED at 2
1 out of 6 hunks FAILED -- saving rejects to file media/libpng/apng.patch.rej

Comment 6

[Glenn Randers-Pehrson]

Attachment: V02 update embedded libpng to version 1.6.22

Fixed cut-and-paste error in patch v01; please try v02

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a9b545317b8

Comment 8

[Glenn Randers-Pehrson]

Comment on attachment 8758053 [details] [diff] [review]
V02 update embedded libpng to version 1.6.22

Libpng-1.6.23 will be out soon (planned release is June 9).

Comment 9

[Seth Fowler [:seth] [:s2h]]

(In reply to Glenn Randers-Pehrson from comment #8)
> Comment on attachment 8758053 [details] [diff] [review]
> V02 update embedded libpng to version 1.6.22
> 
> Libpng-1.6.23 will be out soon (planned release is June 9).

OK, we'll take that one. Let me know when it's ready to go.

Comment 10

[Glenn Randers-Pehrson]

Attachment: V03 update embedded libpng to version 1.6.23 (part 1, libpng)

Please run "try"

Comment 11

[Glenn Randers-Pehrson]

Attachment: V01 update embedded libpng to version 1.6.23 (part 02, old-configure.in)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1072e0f45af5

Comment 13

[Glenn Randers-Pehrson]

Comment on attachment 8761767 [details] [diff] [review]
V03 update embedded libpng to version 1.6.23 (part 1, libpng)

Try looks OK. r?

Comment 14

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8761767 [details] [diff] [review]
V03 update embedded libpng to version 1.6.23 (part 1, libpng)

Review of attachment 8761767 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks, Glenn!

I notice that SSE code has been added, which is great! I did want to bring to your attention that for now, at least, we are still supporting machines that have SSE but not SSE2. I just wanted to make sure you've thought about this, as we've seen some nasty issues related to running SSE2 code on SSE-only machines in the past.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f9d9dfa09d2
Update in-tree libpng to version 1.6.23. r=seth
https://hg.mozilla.org/integration/mozilla-inbound/rev/c84be565e4e8
Update in-tree libpng to version 1.6.23 (part 2, old-configure.in). r=seth

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f9d9dfa09d2
https://hg.mozilla.org/mozilla-central/rev/c84be565e4e8