1275915 - Replace verification sent in-line prompt with platform notification

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: notification.png

Let's use the platform notifications for when the user sends themselves a new verification email. If clicking it does not need to link anywhere, do that. If it does, have it link back to Sync Preferences.

Comment 1

[Edouard Oger [:eoger]]

Attachment: MozReview Request: Bug 1275915 - Replace sync verification panel with platform notification. r?markh

Review commit: https://reviewboard.mozilla.org/r/56700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56700/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8758460 [details]
MozReview Request: Bug 1275915 - Replace sync verification panel with platform notification. r?markh

https://reviewboard.mozilla.org/r/56700/#review53476

LGTM, but I think you should explicitly check with rfeeley that no special styling for the error case is acceptable - I'm slightly worried the user will assume the notification means "it worked" which is why we used different styling in the existing panel.

::: browser/locales/en-US/chrome/browser/accounts.properties:19
(Diff revision 1)
>  reconnectDescription = Reconnect %S
>  
>  # LOCALIZATION NOTE (verifyDescription) - %S = Email address of user's Firefox Account
>  verifyDescription = Verify %S
>  
>  # These strings are shown in a flyout in the Sync preference panel after the

this comment needs updating.

Comment 3

[Ryan Feeley [:rfeeley]]

I think the text is concise enough to be caught on a glance.

Comment 4

[Edouard Oger [:eoger]]

Comment on attachment 8758460 [details]
MozReview Request: Bug 1275915 - Replace sync verification panel with platform notification. r?markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56700/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/b8e12688a664
Replace sync verification panel with platform notification. r=markh

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b8e12688a664

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b8e12688a664

Comment 8

[Azmina]

I have reproduced this bug with Firefox Nightly 49.0a1 (2016-05-26) on windows 8.1 , 64 bit

The bug's fix is verified on Aurora 49.0a2

Build ID : 20160709004037

User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

[testday-20160708]