Closed Bug 1276069 Opened 3 years ago Closed 3 years ago

Full build of Android fails on fedora 23

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect, blocker)

x86_64
Linux
defect
Not set
blocker

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: wgianopoulos, Assigned: glandium)

References

Details

(Keywords: regression)

Attachments

(2 files)

I can no longer build android under fedora 23 since the landing of the patch for bug 1275016.  log files will be forthcoming.
OK not sure i have the correct regressor.  I guess i will wait for the bisect results.  I tried backing out bug 1275016 and still got the same failure.
No longer blocks: 1275016
Nothing landed for bug 1275016. You're also not saying how your build is failing.
I will patch a log file from ndk r11b soon.
(In reply to Bill Gianopoulos [:WG9s] from comment #4)
> I will patch a log file from ndk r11b soon.
         ^^^^^
         post
(In reply to Mike Hommey [:glandium] from comment #2)
> Nothing landed for bug 1275016. You're also not saying how your build is
> failing.

I added a log file i must be confused because somehow i thought i managed to back it out, but it did not fix anything.  i am still waiting for the hg bisect tests then.
That's the very error bug 1275016 comment 12 and subsequent are talking about. IOW, it's kind of a dupe.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1275016
(In reply to Mike Hommey [:glandium] from comment #7)
> That's the very error bug 1275016 comment 12 and subsequent are talking
> about. IOW, it's kind of a dupe.
> 
> *** This bug has been marked as a duplicate of bug 1275016 ***

OK i was confused because bug 1275016 said it had to do with case insensitive filenames, which not an issue under Linux.
Actually, let's separate out the issues, they are kind of independent. The one described here ended up being discussed in bug 1275016 because of the failures on try which are actually due to this bug.
Blocks: 1271829
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee: nobody → mh+mozilla
Besides I was able to build a day after bug 1275016 was filed, but perhaps the filer was building using stuff not yet landed on Mozilla-central.
The intent in bug 1271829 was to make all the XCFLAGS set in
config/external/nss/Makefile.in accumulate instead of replacing each
other. Unfortunately, there is also an AC_SUBST variable named XCFLAGS,
use for other purposes, and we ended up adding on top of that variable.

Using a different local variable allows to still accumulate the values,
while keeping away from the XCFLAGS from autoconf.mk.

Review commit: https://reviewboard.mozilla.org/r/55600/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55600/
Is there any value add of me identifying what patch triggered this issue?
Attachment #8757079 - Flags: review?(nfroyd)
(In reply to Bill Gianopoulos [:WG9s] from comment #12)
> Is there any value add of me identifying what patch triggered this issue?

It's bug 1271829, as written in bug 1275016 comments and as written in comment 11.
Summary: Full build of fx-team fails on fedora 23 → Full build of Android fails on fedora 23
Comment on attachment 8757079 [details]
MozReview Request: Bug 1276069 - Change the local variable used in config/external/nss/Makefile.in to pass down as XCFLAGS to NSS build system

https://reviewboard.mozilla.org/r/55600/#review52332
Attachment #8757079 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/46935fd55a7f
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
And Android taskcluster builds on mozilla-central are green once again - thanks!
Good job!  My builds now work using either ndk-r10e or ndk-r11b.
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 49 → mozilla49
You need to log in before you can comment on or make changes to this bug.