1276069 - Full build of Android fails on fedora 23

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Bill Gianopoulos [:WG9s]]

I can no longer build android under fedora 23 since the landing of the patch for bug 1275016.  log files will be forthcoming.

Comment 1

[Bill Gianopoulos [:WG9s]]

OK not sure i have the correct regressor.  I guess i will wait for the bisect results.  I tried backing out bug 1275016 and still got the same failure.

Comment 2

[Mike Hommey [:glandium]]

Nothing landed for bug 1275016. You're also not saying how your build is failing.

Comment 3

[Bill Gianopoulos [:WG9s]]

Attachment: Log file under ndk r10e

Comment 4

[Bill Gianopoulos [:WG9s]]

I will patch a log file from ndk r11b soon.

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to Bill Gianopoulos [:WG9s] from comment #4)
> I will patch a log file from ndk r11b soon.
         ^^^^^
         post

Comment 6

[Bill Gianopoulos [:WG9s]]

(In reply to Mike Hommey [:glandium] from comment #2)
> Nothing landed for bug 1275016. You're also not saying how your build is
> failing.

I added a log file i must be confused because somehow i thought i managed to back it out, but it did not fix anything.  i am still waiting for the hg bisect tests then.

Comment 7

[Mike Hommey [:glandium]]

That's the very error bug 1275016 comment 12 and subsequent are talking about. IOW, it's kind of a dupe.

Comment 8

[Bill Gianopoulos [:WG9s]]

(In reply to Mike Hommey [:glandium] from comment #7)
> That's the very error bug 1275016 comment 12 and subsequent are talking
> about. IOW, it's kind of a dupe.
> 
> *** This bug has been marked as a duplicate of bug 1275016 ***

OK i was confused because bug 1275016 said it had to do with case insensitive filenames, which not an issue under Linux.

Comment 9

[Mike Hommey [:glandium]]

Actually, let's separate out the issues, they are kind of independent. The one described here ended up being discussed in bug 1275016 because of the failures on try which are actually due to this bug.

Comment 10

[Bill Gianopoulos [:WG9s]]

Besides I was able to build a day after bug 1275016 was filed, but perhaps the filer was building using stuff not yet landed on Mozilla-central.

Comment 11

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1276069 - Change the local variable used in config/external/nss/Makefile.in to pass down as XCFLAGS to NSS build system

The intent in bug 1271829 was to make all the XCFLAGS set in
config/external/nss/Makefile.in accumulate instead of replacing each
other. Unfortunately, there is also an AC_SUBST variable named XCFLAGS,
use for other purposes, and we ended up adding on top of that variable.

Using a different local variable allows to still accumulate the values,
while keeping away from the XCFLAGS from autoconf.mk.

Review commit: https://reviewboard.mozilla.org/r/55600/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55600/

Comment 12

[Bill Gianopoulos [:WG9s]]

Is there any value add of me identifying what patch triggered this issue?

Comment 13

[Mike Hommey [:glandium]]

(In reply to Bill Gianopoulos [:WG9s] from comment #12)
> Is there any value add of me identifying what patch triggered this issue?

It's bug 1271829, as written in bug 1275016 comments and as written in comment 11.

Comment 14

[Nathan Froyd [:froydnj]]

Comment on attachment 8757079 [details]
MozReview Request: Bug 1276069 - Change the local variable used in config/external/nss/Makefile.in to pass down as XCFLAGS to NSS build system

https://reviewboard.mozilla.org/r/55600/#review52332

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46935fd55a7f

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/46935fd55a7f

Comment 17

[Geoff Brown [:gbrown]]

And Android taskcluster builds on mozilla-central are green once again - thanks!

Comment 18

[Bill Gianopoulos [:WG9s]]

Good job!  My builds now work using either ndk-r10e or ndk-r11b.