Closed Bug 1276072 Opened 3 years ago Closed 3 years ago

Update PresentationApp.jsm with the latest Presentation API changes.

Categories

(Firefox for Android :: Screencasting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed

People

(Reporter: schien, Assigned: schien)

References

Details

Attachments

(1 file, 1 obsolete file)

`onstatechange` event interface will be changed and split into three individual event handler: `onconnect`, `onclose`, `onterminate`.

For PresentationApp.jsm we should listen to `onterminate` to have the same semantic.
Haven't tested yet but should be pretty close to final version.
Attachment #8757067 - Flags: feedback?(kechang)
Attachment #8757067 - Flags: feedback?(kechang) → feedback+
Comment on attachment 8757067 [details] [diff] [review]
[WIP] use-onterminate-event.patch

Review of attachment 8757067 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/secondscreen/PresentationApp.jsm
@@ +133,1 @@
>      if (this._session.state !== "connected") {

I think we don't have to check the state again.
Attachment #8757067 - Attachment is obsolete: true
Two modifications:

1) request.startDevice() will be resolved while connection is in connecting state, need to wait until connect to do callback.
2) monitor 'terminate' event instead of 'statechange' event for session termination.
Comment on attachment 8758669 [details]
MozReview Request: Bug 1276072 - wait for 'connect' event and replace 'statechange' event with 'terminate' event. r=kershaw.

https://reviewboard.mozilla.org/r/56888/#review53558
Attachment #8758669 - Flags: review?(kechang) → review+
Pushed by schien@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cb234c21f03
wait for 'connect' event and replace 'statechange' event with 'terminate' event. r=kershaw.
https://hg.mozilla.org/mozilla-central/rev/3cb234c21f03
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.