1276072 - Update PresentationApp.jsm with the latest Presentation API changes.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

`onstatechange` event interface will be changed and split into three individual event handler: `onconnect`, `onclose`, `onterminate`.

For PresentationApp.jsm we should listen to `onterminate` to have the same semantic.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: [WIP] use-onterminate-event.patch

Haven't tested yet but should be pretty close to final version.

Comment 2

[Kershaw Chang [:kershaw]]

Comment on attachment 8757067 [details] [diff] [review]
[WIP] use-onterminate-event.patch

Review of attachment 8757067 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/secondscreen/PresentationApp.jsm
@@ +133,1 @@
>      if (this._session.state !== "connected") {

I think we don't have to check the state again.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: MozReview Request: Bug 1276072 - wait for 'connect' event and replace 'statechange' event with 'terminate' event. r=kershaw.

Review commit: https://reviewboard.mozilla.org/r/56888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56888/

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Two modifications:

1) request.startDevice() will be resolved while connection is in connecting state, need to wait until connect to do callback.
2) monitor 'terminate' event instead of 'statechange' event for session termination.

Comment 5

[Kershaw Chang [:kershaw]]

Comment on attachment 8758669 [details]
MozReview Request: Bug 1276072 - wait for 'connect' event and replace 'statechange' event with 'terminate' event. r=kershaw.

https://reviewboard.mozilla.org/r/56888/#review53558

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cb234c21f03
wait for 'connect' event and replace 'statechange' event with 'terminate' event. r=kershaw.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cb234c21f03