1276119 - Flash produces sound in muted tab

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160517030211
STR:
1. Open data:3,<script>setTimeout("location='http:/dagobah.net/flash/lolicatgirls.swf'",5000)</script>
2. In less than 5 seconds press Ctrl+M to mute tab
3. Wait 10 seconds until the page with flash loads

AR:  Sound
ER:  No sound

This is regression from bug 1242874. Regression range:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=09bb19edf4a807b487e3c7e42f07f9a298001c99&tochange=ea6a844dc6b9dd2094cc9852f44997bf6e7edb24

Comment 1

[Alastor Wu [:alwu]]

[Root cause]
Since we unmute the plug-in in [1] soon after the plug-in was muted.

[Solution]
Since we only support for muting now, the implementation of suspend is equal to muting. Therefore, if we have already muted the plugin,then we don't need to call WindowSuspendChanged() again.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsNPAPIPlugin.cpp#2306

Comment 2

[Alastor Wu [:alwu]]

Attachment: MozReview Request: Bug 1276119 - part1: don't call WindowSuspendChanged if the plugin is already muted.

Review commit: https://reviewboard.mozilla.org/r/55748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55748/

Comment 3

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8129327433bb

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8757169 [details]
MozReview Request: Bug 1276119 - part1: don't call WindowSuspendChanged if the plugin is already muted.

https://reviewboard.mozilla.org/r/55748/#review52874

Comment 5

[Alastor Wu [:alwu]]

Attachment: MozReview Request: Bug 1276119 - part2: add test.

Review commit: https://reviewboard.mozilla.org/r/56252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56252/

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8757169 [details]
MozReview Request: Bug 1276119 - part1: don't call WindowSuspendChanged if the plugin is already muted.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55748/diff/1-2/

Comment 7

[Andrea Marchesini [:baku]]

Comment on attachment 8757893 [details]
MozReview Request: Bug 1276119 - part2: add test.

https://reviewboard.mozilla.org/r/56252/#review52884

Comment 8

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f01c079a8e76

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c27e49247fe2
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba07e25e6d1d

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c27e49247fe2
https://hg.mozilla.org/mozilla-central/rev/ba07e25e6d1d