Closed
Bug 1276198
Opened 8 years ago
Closed 8 years ago
Update about:telemetry to show scalars and keyedScalars
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla50
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
(Blocks 1 open bug)
Details
(Whiteboard: [measurement:client])
Attachments
(3 files)
1.46 KB,
patch
|
Details | Diff | Splinter Review | |
5.13 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
6.15 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
We will need to show separate sections for the |scalars| and |keyedScalars| fields. We can start this off as plain tables, filtering them etc. is not required. This is not really blocked by other scalar work and could just be implemented based on test data.
Assignee | ||
Updated•8 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gfritzsche
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
This adds trivial rendering of the scalar measurements as a key-value-table. Lets defer adding a keyed scalar section to bug 1277806.
Attachment #8761525 -
Flags: review?(alessio.placitelli)
Assignee | ||
Comment 3•8 years ago
|
||
This moves less commonly used about:telemetry sections further down to make the page more convenient to use.
Attachment #8761527 -
Flags: review?(alessio.placitelli)
Assignee | ||
Updated•8 years ago
|
Priority: P3 → P1
Assignee | ||
Updated•8 years ago
|
Points: --- → 1
Comment 4•8 years ago
|
||
Comment on attachment 8761525 [details] [diff] [review] Update about:telemetry to show scalar measurements Review of attachment 8761525 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/content/aboutTelemetry.js @@ +1552,5 @@ > > +var Scalars = { > + /** > + * Render the scalar data - if present - from the payload in a simple key-value table. > + * @param aPing A payload object to render the data from. nit: aPing -> aPayload
Attachment #8761525 -
Flags: review?(alessio.placitelli) → review+
Updated•8 years ago
|
Attachment #8761527 -
Flags: review?(alessio.placitelli) → review+
Pushed by georg.fritzsche@googlemail.com: https://hg.mozilla.org/integration/fx-team/rev/2d81d52f4039 Update about:telemetry to show scalar measurements. r=dexter https://hg.mozilla.org/integration/fx-team/rev/ce7f534b2580 Bonus: re-order main ping sections in about:telemetry by importance. r=dexter
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2d81d52f4039 https://hg.mozilla.org/mozilla-central/rev/ce7f534b2580
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•