Update about:telemetry to show scalars and keyedScalars

RESOLVED FIXED in Firefox 50

Status

()

defect
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gfritzsche, Assigned: gfritzsche)

Tracking

(Blocks 1 bug)

Trunk
mozilla50
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox49 affected, firefox50 fixed)

Details

(Whiteboard: [measurement:client])

Attachments

(3 attachments)

We will need to show separate sections for the |scalars| and |keyedScalars| fields.
We can start this off as plain tables, filtering them etc. is not required.

This is not really blocked by other scalar work and could just be implemented based on test data.
Assignee

Updated

3 years ago
Priority: -- → P3
Assignee

Updated

3 years ago
Assignee: nobody → gfritzsche
Status: NEW → ASSIGNED
Assignee

Comment 2

3 years ago
This adds trivial rendering of the scalar measurements as a key-value-table. Lets defer adding a keyed scalar section to bug 1277806.
Attachment #8761525 - Flags: review?(alessio.placitelli)
Assignee

Comment 3

3 years ago
This moves less commonly used about:telemetry sections further down to make the page more convenient to use.
Attachment #8761527 - Flags: review?(alessio.placitelli)
Assignee

Updated

3 years ago
Priority: P3 → P1
Assignee

Updated

3 years ago
Points: --- → 1
Comment on attachment 8761525 [details] [diff] [review]
Update about:telemetry to show scalar measurements

Review of attachment 8761525 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutTelemetry.js
@@ +1552,5 @@
>  
> +var Scalars = {
> +  /**
> +   * Render the scalar data - if present - from the payload in a simple key-value table.
> +   * @param aPing A payload object to render the data from.

nit: aPing -> aPayload
Attachment #8761525 - Flags: review?(alessio.placitelli) → review+
Attachment #8761527 - Flags: review?(alessio.placitelli) → review+

Comment 5

3 years ago
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/fx-team/rev/2d81d52f4039
Update about:telemetry to show scalar measurements. r=dexter
https://hg.mozilla.org/integration/fx-team/rev/ce7f534b2580
Bonus: re-order main ping sections in about:telemetry by importance. r=dexter

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2d81d52f4039
https://hg.mozilla.org/mozilla-central/rev/ce7f534b2580
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.