1276341 - replace uses of Cu.import

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

The uses of Cu.import in the inspector and its dependencies will have to
be replaced (probably with "require") as part of the de-chrome-ification project.

Comment 1

[Tom Tromey :tromey]

Probably this should be broken down by import target.
There are a lot of imports, even excluding tests and the server:

pokyo. git grep Cu.import -- devtools/|grep -v /server |grep -v /test |wc -l
243

On irc :jryans pointed out that event-emitter.js imports are readily done:

https://dxr.mozilla.org/mozilla-central/search?q=Cu.import+event-emitter+path%3Adevtools&redirect=false%29

Comment 2

[Tom Tromey :tromey]

Attachment: Bug 1276341 - remove some misleading import comments;

Review commit: https://reviewboard.mozilla.org/r/56920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56920/

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8758724 [details]
Bug 1276341 - remove some misleading import comments;

Wrong bug.

Comment 4

[Tom Tromey :tromey]

Let's not forget lazyImporter as well.

Comment 5

[Tom Tromey :tromey]

It turns out that there are only a few imports that are directly addressable.
The others have to be part of some other bug; for example actor-registry.js is
using Cu.import, but I think that one (IIUC, which I'm not sure I do) probably
has to be address with some other transport changes.

I'll upload a patch for the few I found.

Comment 6

[Tom Tromey :tromey]

Attachment: Bug 1276341 - don't use Cu.import for event-emitter.js;

Review commit: https://reviewboard.mozilla.org/r/65652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65652/

Comment 7

[Tom Tromey :tromey]

Comment on attachment 8758724 [details]
Bug 1276341 - remove some misleading import comments;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56920/diff/1-2/

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8758724 [details]
Bug 1276341 - remove some misleading import comments;

https://reviewboard.mozilla.org/r/56920/#review62982

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8773013 [details]
Bug 1276341 - don't use Cu.import for event-emitter.js;

https://reviewboard.mozilla.org/r/65652/#review63022

Looks good!  I was thinking there would be more to do here, but I guess the others are in test files or they are imports of JSMs which probably need a focus of their own, since they either don't work in content or at least contain more imports.

Comment 10

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2173660df544

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8980a789ce92
remove some misleading import comments; r=jryans
https://hg.mozilla.org/integration/autoland/rev/42532fefe293
don't use Cu.import for event-emitter.js; r=jryans

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8980a789ce92
https://hg.mozilla.org/mozilla-central/rev/42532fefe293