Implement receiving 'b=TIAS' on media description to restrict sending bandwidth

RESOLVED FIXED in Firefox 49

Status

()

defect
P2
normal
Rank:
25
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: drno, Assigned: drno)

Tracking

Trunk
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

No description provided.
backlog: --- → webrtc/webaudio+
Rank: 25
Priority: -- → P2
See Also: → 1276372
Comment on attachment 8757504 [details]
Bug 1276368: use b=TIAS for maxBitrate encoding constraints.

https://reviewboard.mozilla.org/r/55942/#review52686

::: media/webrtc/signaling/src/jsep/JsepTrackEncoding.h:45
(Diff revision 1)
> +    mConstraints.maxBr = std::min(tias? tias:mConstraints.maxBr,
> +                                  mConstraints.maxBr? mConstraints.maxBr:tias);

spaces around ? and :

::: media/webrtc/signaling/src/jsep/JsepTrackEncoding.h:47
(Diff revision 1)
> +  void UpdateMaxBitrate(const SdpMediaSection& remote)
> +  {
> +    uint32_t tias = remote.GetBandwidth("TIAS");
> +    mConstraints.maxBr = std::min(tias? tias:mConstraints.maxBr,
> +                                  mConstraints.maxBr? mConstraints.maxBr:tias);
> +    // TODO do we want b=AS support?  I don't think so

b=AS is worse, true.  However... Chrome is using b=AS last I checked, and apps assume (for now) they can manipulate b=AS.  Some interop uses (likely not spark, but others) may use b=AS.  So we should think hard about it before deciding not to... but in any case that's a separate (though related) bug.
Attachment #8757504 - Flags: review?(rjesup) → review+
Comment on attachment 8757504 [details]
Bug 1276368: use b=TIAS for maxBitrate encoding constraints.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55942/diff/1-2/
Attachment #8757504 - Attachment description: MozReview Request: Bug 1276368: use b=TIAS for maxBitrate encoding constraints. r=jesup → Bug 1276368: use b=TIAS for maxBitrate encoding constraints.
Comment on attachment 8757504 [details]
Bug 1276368: use b=TIAS for maxBitrate encoding constraints.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55942/diff/2-3/
See Also: → 1278001
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/403728f309ce
use b=TIAS for maxBitrate encoding constraints. r=jesup
Just a note: as of now this enables to restrict a single outgoing video stream to a given bandwidth (according to b=TIAS). But restricting multiple senders does not work as expected as per bug 1278001.
https://hg.mozilla.org/mozilla-central/rev/403728f309ce
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.