1276368 - Implement receiving 'b=TIAS' on media description to restrict sending bandwidth

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1276368: use b=TIAS for maxBitrate encoding constraints.

Review commit: https://reviewboard.mozilla.org/r/55942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55942/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8757504 [details]
Bug 1276368: use b=TIAS for maxBitrate encoding constraints.

https://reviewboard.mozilla.org/r/55942/#review52686

::: media/webrtc/signaling/src/jsep/JsepTrackEncoding.h:45
(Diff revision 1)
> +    mConstraints.maxBr = std::min(tias? tias:mConstraints.maxBr,
> +                                  mConstraints.maxBr? mConstraints.maxBr:tias);

spaces around ? and :

::: media/webrtc/signaling/src/jsep/JsepTrackEncoding.h:47
(Diff revision 1)
> +  void UpdateMaxBitrate(const SdpMediaSection& remote)
> +  {
> +    uint32_t tias = remote.GetBandwidth("TIAS");
> +    mConstraints.maxBr = std::min(tias? tias:mConstraints.maxBr,
> +                                  mConstraints.maxBr? mConstraints.maxBr:tias);
> +    // TODO do we want b=AS support?  I don't think so

b=AS is worse, true.  However... Chrome is using b=AS last I checked, and apps assume (for now) they can manipulate b=AS.  Some interop uses (likely not spark, but others) may use b=AS.  So we should think hard about it before deciding not to... but in any case that's a separate (though related) bug.

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8757504 [details]
Bug 1276368: use b=TIAS for maxBitrate encoding constraints.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55942/diff/1-2/

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8757504 [details]
Bug 1276368: use b=TIAS for maxBitrate encoding constraints.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55942/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/403728f309ce
use b=TIAS for maxBitrate encoding constraints. r=jesup

Comment 6

[Nils Ohlmeier [:drno]]

Just a note: as of now this enables to restrict a single outgoing video stream to a given bandwidth (according to b=TIAS). But restricting multiple senders does not work as expected as per bug 1278001.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/403728f309ce