Closed Bug 1276399 Opened 8 years ago Closed 8 years ago

Remove now-unused privateIsNSISupports JSContext option

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Remove the now-unused privateIsNSISupports JSContext option
1.43 KB, patch
jandem
: review+
Details | Diff | Splinter Review 
After 1276276 Gecko no longer uses nsISupports privates on JSContexts, and the one remaining user of dontReportUncaught is silly because it's already got autoJSAPIOwnsErrorReporting.
Actually, looks like there are more users of dontReportUncaught.  Let's stick to privateIsNSISupports here for now.
Summary: Remove now-unused JSContext options → Remove now-unused privateIsNSISupports JSContext option
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8757548 [details] [diff] [review]
Remove the now-unused privateIsNSISupports JSContext option

Review of attachment 8757548 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, privateIsNSISupports always seemed too Gecko-specific.
Attachment #8757548 - Flags: review?(jdemooij) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61988719cd2a
Remove the now-unused privateIsNSISupports JSContext option.  r=jandem
https://hg.mozilla.org/mozilla-central/rev/61988719cd2a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.