Closed
Bug 1276418
Opened 8 years ago
Closed 8 years ago
Intermittent e10s browser_inspector_initialization.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(e10s+, firefox49 wontfix, firefox50 fixed, firefox51 fixed, firefox52 fixed)
RESOLVED
FIXED
Firefox 52
People
(Reporter: aryx, Assigned: pbro)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1210671 +++ https://treeherder.mozilla.org/logviewer.html#?job_id=28962914&repo=mozilla-inbound
Updated•8 years ago
|
tracking-e10s:
--- → ?
Updated•8 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 12•8 years ago
|
||
Patrick, looks like you've cleaned up CPOW usage in this test previously. This particular failure is still one of the more frequent dead CPOW oranges we're hitting, though :(. Can you please take a look when you get a chance?
Assignee | ||
Comment 13•8 years ago
|
||
Taking this one, the CPOW is quite obvious here. The test still uses getNode which access DOM node in the content page directly. I thought we had already eradicated them all, but some still remain.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Flags: needinfo?(pbrosset)
Comment hidden (mozreview-request) |
Comment hidden (Intermittent Failures Robot) |
Comment 16•8 years ago
|
||
mozreview-review |
Comment on attachment 8791980 [details] Bug 1276418 - Remove getNode and all references to it in inspector tests; https://reviewboard.mozilla.org/r/79254/#review77998 ::: devtools/client/inspector/layout/test/head.js:22 (Diff revision 1) > -} > - > -/** > * Highlight a node and set the inspector's current selection to the node or > * the first match of the given css selector. > - * @param {String|DOMNode} nodeOrSelector > + * @param {String} selectorOrNodeFront Should be {String|NodeFront}
Attachment #8791980 -
Flags: review?(gl) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 18•8 years ago
|
||
Thanks for the review. Here's a green try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f695f7accecd&group_state=expanded (eslint is red, but I've fixed the issue locally since then). Going to land this.
Comment 19•8 years ago
|
||
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/690b85efea25 Remove getNode and all references to it in inspector tests; r=gl
Comment 20•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/690b85efea25
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment 21•8 years ago
|
||
Interestingly, both browser_styleinspector_csslogic-content-stylesheets.js and browser_inspector_initialization.js were disabled on debug e10s for docshell leaks. I wonder if that's still true after their deCPOWification.
Comment 22•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/cda507ba2b3b
Flags: in-testsuite+
Comment 23•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/45c968b10c64
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•