Closed Bug 1276518 Opened 4 years ago Closed 4 years ago
Print Job argument for Show Progress should be nullable
58 bytes, text/x-review-board-request
If you turn off printing via the parent ShowProgress crashes because PRemotePrintJob can be null. I noticed this crash before landing bug 1189846, but clearly I lost the change somewhere.
Review commit: https://reviewboard.mozilla.org/r/56112/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56112/
Attachment #8757713 - Flags: review?(jmathies)
Comment on attachment 8757713 [details] MozReview Request: Bug 1276518: Make PRemotePrintJob argument for ShowProgress nullable. https://reviewboard.mozilla.org/r/56112/#review53118
How does adding 'nullable' prevent the crash?
(In reply to Jim Mathies [:jimm] from comment #3) > How does adding 'nullable' prevent the crash? Because otherwise we call FatalError in the IPDL generated code, if we pass null. This dxr link may not be permanent, but making it nullable passes true here: https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/ipc/ipdl/PPrintingChild.cpp#115 This calls: https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/ipc/ipdl/PPrintingChild.cpp#1323
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/389345ac8f73 Make PRemotePrintJob argument for ShowProgress nullable. r=jimm
You need to log in before you can comment on or make changes to this bug.