Closed Bug 1276518 Opened 4 years ago Closed 4 years ago

PRemotePrintJob argument for ShowProgress should be nullable

Categories

(Core :: Printing: Output, defect)

49 Branch
All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

(Whiteboard: sbwc1)

Attachments

(1 file)

If you turn off printing via the parent ShowProgress crashes because PRemotePrintJob can be null.

I noticed this crash before landing bug 1189846, but clearly I lost the change somewhere.
Attachment #8757713 - Flags: review?(jmathies) → review+
Comment on attachment 8757713 [details]
MozReview Request: Bug 1276518: Make PRemotePrintJob argument for ShowProgress nullable.

https://reviewboard.mozilla.org/r/56112/#review53118
How does adding 'nullable' prevent the crash?
(In reply to Jim Mathies [:jimm] from comment #3)
> How does adding 'nullable' prevent the crash?

Because otherwise we call FatalError in the IPDL generated code, if we pass null.

This dxr link may not be permanent, but making it nullable passes true here:
https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/ipc/ipdl/PPrintingChild.cpp#115

This calls:
https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/ipc/ipdl/PPrintingChild.cpp#1323
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/389345ac8f73
Make PRemotePrintJob argument for ShowProgress nullable. r=jimm
https://hg.mozilla.org/mozilla-central/rev/389345ac8f73
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.