1276518 - PRemotePrintJob argument for ShowProgress should be nullable

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Bob Owen (:bobowen)]

If you turn off printing via the parent ShowProgress crashes because PRemotePrintJob can be null.

I noticed this crash before landing bug 1189846, but clearly I lost the change somewhere.

Comment 1

[Bob Owen (:bobowen)]

Attachment: MozReview Request: Bug 1276518: Make PRemotePrintJob argument for ShowProgress nullable.

Review commit: https://reviewboard.mozilla.org/r/56112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56112/

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8757713 [details]
MozReview Request: Bug 1276518: Make PRemotePrintJob argument for ShowProgress nullable.

https://reviewboard.mozilla.org/r/56112/#review53118

Comment 3

[Jim Mathies [:jimm]]

How does adding 'nullable' prevent the crash?

Comment 4

[Bob Owen (:bobowen)]

(In reply to Jim Mathies [:jimm] from comment #3)
> How does adding 'nullable' prevent the crash?

Because otherwise we call FatalError in the IPDL generated code, if we pass null.

This dxr link may not be permanent, but making it nullable passes true here:
https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/ipc/ipdl/PPrintingChild.cpp#115

This calls:
https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/ipc/ipdl/PPrintingChild.cpp#1323

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/389345ac8f73
Make PRemotePrintJob argument for ShowProgress nullable. r=jimm

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/389345ac8f73