Closed Bug 1276549 Opened 4 years ago Closed 4 years ago

Remove rvalue reference mark from already_AddRefed param of nsIEventTarget::Dispatch and related methods

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Since already_AddRefed is only move-constructible, but not copy-constructible, removing "&&" wouldn't affect soundness.

In addition, using non-reference declarator in params should theoritically give compilers more optimization chance at callsites, because it can be reasoned out that the pointer inside would always be reset to zero after being moved. (This doesn't matter much for already_AddRefed, though, as this type doesn't have non-trivial destructor for release build.)
Assignee: nobody → bugzilla
Attachment #8757756 - Flags: review?(nfroyd) → review+
Comment on attachment 8757756 [details]
MozReview Request: Bug 1276549 - Remove rvalue reference mark for already_AddRefed params of nsIEventTarget::Dispatch and related methods. r?froydnj

https://reviewboard.mozilla.org/r/56180/#review53328

I guess this is consistent with what we already do for things like UniquePtr.
https://hg.mozilla.org/integration/mozilla-inbound/rev/aeca77cdf8eaa8be001f4eb17174f28c505cdd3d
Bug 1276549 - Remove rvalue reference mark for already_AddRefed params of nsIEventTarget::Dispatch and related methods. r=froydnj
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aeca77cdf8ea
Remove rvalue reference mark for already_AddRefed params of nsIEventTarget::Dispatch and related methods. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/aeca77cdf8ea
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.