1276549 - Remove rvalue reference mark from already_AddRefed param of nsIEventTarget::Dispatch and related methods

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Since already_AddRefed is only move-constructible, but not copy-constructible, removing "&&" wouldn't affect soundness.

In addition, using non-reference declarator in params should theoritically give compilers more optimization chance at callsites, because it can be reasoned out that the pointer inside would always be reset to zero after being moved. (This doesn't matter much for already_AddRefed, though, as this type doesn't have non-trivial destructor for release build.)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1276549 - Remove rvalue reference mark for already_AddRefed params of nsIEventTarget::Dispatch and related methods. r?froydnj

Review commit: https://reviewboard.mozilla.org/r/56180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56180/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8757756 [details]
MozReview Request: Bug 1276549 - Remove rvalue reference mark for already_AddRefed params of nsIEventTarget::Dispatch and related methods. r?froydnj

https://reviewboard.mozilla.org/r/56180/#review53328

I guess this is consistent with what we already do for things like UniquePtr.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aeca77cdf8eaa8be001f4eb17174f28c505cdd3d
Bug 1276549 - Remove rvalue reference mark for already_AddRefed params of nsIEventTarget::Dispatch and related methods. r=froydnj

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aeca77cdf8ea
Remove rvalue reference mark for already_AddRefed params of nsIEventTarget::Dispatch and related methods. r=froydnj

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aeca77cdf8ea