1276567 - Fix -Wstring-conversion warnings in js/ directory

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Peterson [:cpeterson]]

clang's -Wstring-conversion warning warns about the use of string literals as boolean expressions. This is not uncommon in "always fail" assertions, but MOZ_ASSERT_UNREACHABLE() or MOZ_CRASH() are better solutions.

Is it safe to assert (or even MOZ_CRASH) in the "<dead CPOW>" case of WrapperAnswer::RecvClassName()?

js/ipc/WrapperAnswer.cpp:531:16 [-Wstring-conversion] implicit conversion turns string literal into bool: 'const char [12]' to 'bool'
js/src/jit/MIR.h:63:25 [-Wstring-conversion] implicit conversion turns string literal into bool: 'const char [26]' to 'bool'
js/src/jit/SharedIC.cpp:1648:21 [-Wstring-conversion] implicit conversion turns string literal into bool: 'const char [30]' to 'bool'
js/src/jsgc.cpp:7135:21 [-Wstring-conversion] implicit conversion turns string literal into bool: 'const char [59]' to 'bool'

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Fix -Wstring-conversion warnings in js/ directory

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8757770 [details] [diff] [review]
Fix -Wstring-conversion warnings in js/ directory

Review of attachment 8757770 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/ipc/WrapperAnswer.cpp
@@ +550,5 @@
>      RootedObject obj(cx, findObjectById(cx, objId));
>      if (!obj) {
>          // This is very unfortunate, but we have no choice.
> +        MOZ_ASSERT_UNREACHABLE("<dead CPOW>");
> +        return false;

This should assign "<dead CPOW>" to *name and return true.

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: Wstring-conversion_dead-CPOW-v2.patch

Patch v2 assigns "<dead CPOW>" to *name and returns true.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d71c62d3caa
Fix -Wstring-conversion warnings in js/ directory. r=billm

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3d71c62d3caa