(DLC) SyncAction: Use Switchboard.isInExperiment() instead of Experiments.isInExperimentLocal()

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sebastian, Assigned: k.krish, Mentored)

Tracking

unspecified
Firefox 49
All
Android
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
From bug 1201059 comment 24.

SyncAction uses Experiments.isInExperimentLocal() to test if it is enabled:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/dlc/SyncAction.java#237

Instead we should have used Switchboard.isInExperiment() like we do here in BrowserApp:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#2318

Background: We use Switchboard to enable the synchronization of the downloadable content catalog for 50% of our Nightly users. isInExperimentLocal() exists just for the first run tour where we need to decide if the user is in the experiment before the first start of the app (=> We can't ask the servers first and delay app start).
(Assignee)

Comment 1

3 years ago
Created attachment 8758002 [details]
MozReview Request: Removing unused method - DownloadContentCatalog: markAsIgnored()

Review commit: https://reviewboard.mozilla.org/r/56356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56356/
(Assignee)

Comment 2

3 years ago
Created attachment 8758003 [details]
Bug1276577 Using Switchboard.isInExperiment()

Review commit: https://reviewboard.mozilla.org/r/56358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56358/
(Assignee)

Updated

3 years ago
Attachment #8758002 - Attachment is obsolete: true
(Reporter)

Comment 3

3 years ago
Comment on attachment 8758003 [details]
Bug1276577 Using Switchboard.isInExperiment()

https://reviewboard.mozilla.org/r/56358/#review52952

This looks good. Thank you!

It seems like you accidentally pushed two commits. Mercurial's bookmarks are helpful here (They are pretty much like git branches). For every new bug create a new bookmark from fx-team or mozilla-central (depending what repository you are working on). Then just push this new bookmark to reviewboard.

Here are some helpful links:
* https://www.mercurial-scm.org/wiki/Bookmarks
* http://mercurial.aragost.com/kick-start/en/bookmarks/
* http://mozilla-version-control-tools.readthedocs.io/en/latest/hgmozilla/bookmarks.html
Attachment #8758003 - Flags: review+
(Assignee)

Comment 4

3 years ago
Yes, I was trying out the review board for the first time. Accidentally pushed two commits. 
Thanks for the guidance.
(Reporter)

Comment 5

3 years ago
Krish: Can you get this landed?
(Assignee)

Comment 6

3 years ago
Comment on attachment 8758003 [details]
Bug1276577 Using Switchboard.isInExperiment()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56358/diff/1-2/
Attachment #8758003 - Attachment description: MozReview Request: Bug1276577 Using Switchboard.isInExperiment() → Bug1276577 Using Switchboard.isInExperiment()
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 8

3 years ago
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/d1c3952c299d
Using Switchboard.isInExperiment() r=sebastian
Keywords: checkin-needed

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d1c3952c299d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.