1276577 - (DLC) SyncAction: Use Switchboard.isInExperiment() instead of Experiments.isInExperimentLocal()

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

From bug 1201059 comment 24.

SyncAction uses Experiments.isInExperimentLocal() to test if it is enabled:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/dlc/SyncAction.java#237

Instead we should have used Switchboard.isInExperiment() like we do here in BrowserApp:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#2318

Background: We use Switchboard to enable the synchronization of the downloadable content catalog for 50% of our Nightly users. isInExperimentLocal() exists just for the first run tour where we need to decide if the user is in the experiment before the first start of the app (=> We can't ask the servers first and delay app start).

Comment 1

[k.krish]

Attachment: MozReview Request: Removing unused method - DownloadContentCatalog: markAsIgnored()

Review commit: https://reviewboard.mozilla.org/r/56356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56356/

Comment 2

[k.krish]

Attachment: Bug1276577 Using Switchboard.isInExperiment()

Review commit: https://reviewboard.mozilla.org/r/56358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56358/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8758003 [details]
Bug1276577 Using Switchboard.isInExperiment()

https://reviewboard.mozilla.org/r/56358/#review52952

This looks good. Thank you!

It seems like you accidentally pushed two commits. Mercurial's bookmarks are helpful here (They are pretty much like git branches). For every new bug create a new bookmark from fx-team or mozilla-central (depending what repository you are working on). Then just push this new bookmark to reviewboard.

Here are some helpful links:
* https://www.mercurial-scm.org/wiki/Bookmarks
* http://mercurial.aragost.com/kick-start/en/bookmarks/
* http://mozilla-version-control-tools.readthedocs.io/en/latest/hgmozilla/bookmarks.html

Comment 4

[k.krish]

Yes, I was trying out the review board for the first time. Accidentally pushed two commits. 
Thanks for the guidance.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Krish: Can you get this landed?

Comment 6

[k.krish]

Comment on attachment 8758003 [details]
Bug1276577 Using Switchboard.isInExperiment()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56358/diff/1-2/

Comment 7

[k.krish]

Try Results 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc541c5ea59f&selectedJob=21962187

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/d1c3952c299d
Using Switchboard.isInExperiment() r=sebastian

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d1c3952c299d