Closed Bug 1276577 Opened 7 years ago Closed 7 years ago
Action: Use Switchboard .is In Experiment() instead of Experiments .is In Experiment Local()
From bug 1201059 comment 24. SyncAction uses Experiments.isInExperimentLocal() to test if it is enabled: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/dlc/SyncAction.java#237 Instead we should have used Switchboard.isInExperiment() like we do here in BrowserApp: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#2318 Background: We use Switchboard to enable the synchronization of the downloadable content catalog for 50% of our Nightly users. isInExperimentLocal() exists just for the first run tour where we need to decide if the user is in the experiment before the first start of the app (=> We can't ask the servers first and delay app start).
Review commit: https://reviewboard.mozilla.org/r/56356/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56356/
Review commit: https://reviewboard.mozilla.org/r/56358/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56358/
Comment on attachment 8758003 [details] Bug1276577 Using Switchboard.isInExperiment() https://reviewboard.mozilla.org/r/56358/#review52952 This looks good. Thank you! It seems like you accidentally pushed two commits. Mercurial's bookmarks are helpful here (They are pretty much like git branches). For every new bug create a new bookmark from fx-team or mozilla-central (depending what repository you are working on). Then just push this new bookmark to reviewboard. Here are some helpful links: * https://www.mercurial-scm.org/wiki/Bookmarks * http://mercurial.aragost.com/kick-start/en/bookmarks/ * http://mozilla-version-control-tools.readthedocs.io/en/latest/hgmozilla/bookmarks.html
Attachment #8758003 - Flags: review+
Yes, I was trying out the review board for the first time. Accidentally pushed two commits. Thanks for the guidance.
Krish: Can you get this landed?
Comment on attachment 8758003 [details] Bug1276577 Using Switchboard.isInExperiment() Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56358/diff/1-2/
Attachment #8758003 - Attachment description: MozReview Request: Bug1276577 Using Switchboard.isInExperiment() → Bug1276577 Using Switchboard.isInExperiment()
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/fx-team/rev/d1c3952c299d Using Switchboard.isInExperiment() r=sebastian
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.