1276607 - The pointer from the text box is missing after disabling RDM

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Mihai Boldan, Desktop QA [:mboldan]]

Attachment: missing pointer.gif

[Note]:
- Logged based on Bug 1240913 Comment 56

[Affected versions]:
- Firefox 49.0a1 (2016-05-29)

[Affected platforms]:
- Windows 10 x64, Ubunut 16.04 x64 and Mac OS X 10.10.5

[Steps to reproduce]:
1. Launch Firefox.
2. From about:config, enable the devtools.responsive.html.enabled pref.
3. Go to https://www.google.com.
4. Enable RDM.
5. Disable RDM and observe the pointer from the text box.

[Expected result]:
- The pointer is correctly displayed.

[Actual result]:
- After disabling RDM, the pointer is hidden (see the attached video).

[Regression range]:
- I think that this issue is caused by Bug 1240913. I'll investigate asap.

Comment 1

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to find a regression range Last good (2016-05-19) - First bad (2016-05-20).
Here is the pushlog from mozregression: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c4449eab07d39e20ea315603f1b1863eeed7dcfe&tochange=c67dc1f9fab86d4f2cf3224307809c44fe3ce820

Let me know if I can help any further with the investigation.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this feature enabled on release? Or is this something still in the works for the future and preffed off past aurora?

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The feature is not enabled anywhere by default yet.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks, that's what I thought. Marking this issue fix-optional for 49/50 (we don't really need to track it yet, but it's showing up on platform regression triage)

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1276607 - Activate content frame when stopping RDM to restore focus.

Review commit: https://reviewboard.mozilla.org/r/71046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71046/

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b1872b25a50

Comment 7

[Benoit Chabod [:bigben]]

Comment on attachment 8780324 [details]
Bug 1276607 - Activate content frame when stopping RDM to restore focus.

https://reviewboard.mozilla.org/r/71046/#review68656

Looks good to me!
Failures are related to intermittent bugs only, and that fix worked well when I tested it locally.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e225f606ad70
Activate content frame when stopping RDM to restore focus. r=bigben

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e225f606ad70

Comment 10

[Mihai Boldan, Desktop QA [:mboldan]]

The issue is no longer reproducible on Firefox 51.0a1 (2016-08-16), under Windows 10x64, Mac OS X 10.11.1 and under Ubuntu 14.04 x64.
I am marking this issue Verified Fixed.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Ryan, should we consider uplifting this to Beta50? It's tagged as a P1.

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Ritu Kothari (:ritu) from comment #11)
> Hi Ryan, should we consider uplifting this to Beta50? It's tagged as a P1.

No, the feature is disabled by default.  I've updated the tracking flags.